Feature add outcome to feedback #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spuetz
requested changes
Sep 26, 2018
|
@howardcochran Would be cool if you do the changes I've suggested. After that we could merge that. :) |
added 3 commits
October 3, 2018 22:21
These fields will allow external entity to understand why a MoveBase or ExePath action is currently failing before it actually gives up.
This can enable an external monitor to understand why the controller is failing before the MoveBase or ExePath action gives up on the goal. This makes it possible for external logic to decide when to trigger a recovery behavior, for example.
howardcochran
force-pushed
the
feature-add-outcome-to-feedback
branch
from
14e11b9 to
84e79d7
Compare
|
Thanks for the feedback, @spuetz. I have rewritten the commits with the requested changes and rebased the branch on 0.2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #77 "Improvements to ExePathFeedback
(and MoveBaseFeedback)"