Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor addition and fixes to code related to transmitters, skeletonisation and CAVE tokens #213

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

alexanderbates
Copy link
Contributor

  • updates to work with different CAVE projects
    • pass domain to chunkedgraph_token and
    • add domain argument to flywire_fetch, so that fafbseg can work with other, non-flywire projects more easily, e.g. CRANTb
  • export as.neuron.navis.core.dotprop.Dotprops
  • updates to transmitter paper reference and management of transmitter labels for FlyWire-FAFB synapses
  • updates to skeletonisation function,
    • do not pass methods to py_run_string, enable different reroot methods
    • heal attempt only if >1 trees in skeleton

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 35.00000% with 39 lines in your changes missing coverage. Please review.

Project coverage is 58.09%. Comparing base (e551983) to head (7519583).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
R/autosyn.R 0.00% 32 Missing ⚠️
R/flywire-skeleton.R 74.07% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
- Coverage   58.22%   58.09%   -0.13%     
==========================================
  Files          39       39              
  Lines        5235     5274      +39     
==========================================
+ Hits         3048     3064      +16     
- Misses       2187     2210      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jefferis
Copy link
Collaborator

@alexanderbates can you explain a bit more about the handling of URLs that you might be fetching vs domains? I don't think they are the same. In particular a token that applies for a certain "domain" might be appropriate to fetch URLs that do not contain that domain name. Can you give specific examples? Contact me privately if necessary.

* `flywire_fetch` can be given 'domain' to enable it to discriminate between different domains for CAVE projects. This is passed to `chunkedgraph_token` as an argument called `url`. It was already called this, I think we can change it also to be `domain`? We can have both `url` and `domain` for `flywire_fetch`, where by default `domain=url` for cases where these could be different?
@alexanderbates
Copy link
Contributor Author

Ah I see what you mean. flywire_fetch can be given 'domain' to enable it to discriminate between different domains for CAVE projects. This is passed to chunkedgraph_token as an argument called url. It was already called this, I think we can change it also to be domain? We can have both url and domain for flywire_fetch, where by default domain=url for cases where these could be different?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants