Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump cibuildwheel to correctly build py312 #44

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

adehad
Copy link
Contributor

@adehad adehad commented Jul 8, 2024

Hi @naufraghi,

Currently the py312 wheels are not present on pypi https://pypi.org/project/tinyaes/1.1.0/#files

Reviewing the changelog history for cibuildwheel: https://cibuildwheel.pypa.io/en/stable/changelog/
I believe the issue is because Python 3.12 was under the pre-release support at the current version used in the GitHub Action.

This change I believe should correctly pick up the new configuration to build the Python3.12 wheel as expected.

I believe the minimum version would be 2.15: https://cibuildwheel.pypa.io/en/stable/changelog/#v2150

@naufraghi naufraghi merged commit f31914e into naufraghi:master Aug 13, 2024
@naufraghi
Copy link
Owner

Merged to test it, thanks!

@adehad
Copy link
Contributor Author

adehad commented Aug 13, 2024

Thanks, it may also be worth bumping to this now to: https://cibuildwheel.pypa.io/en/stable/changelog/#v2200

So you could also release a 3.13 compatible wheel?
(not sure if there are any further implications, but worth keeping in mind now that the 3.13 rc has been released)

@naufraghi
Copy link
Owner

I'm bumping a few more deps, I'll add that to the list.

@adehad
Copy link
Contributor Author

adehad commented Aug 13, 2024

Nice one, I also made a start here: #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants