Align json option with request, improved to include input from #134 comments #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW. This change wouldn't be possible with everyone's inputs. Big thanks to @bjoerge, @wesleytodd, @TehShrike, @mhart for enabling it! |
naugtur
changed the title
|
Looks good to me! LGTM |
|
@naugtur Do you anticipate merging this in soon? It would be great to have. |
…option-with-request
|
I hoped for a discussion, but I'm certain this is a good change. |
|
Agreed, I am unsure what else there would be to discuss. This was released in |
|
Correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took #135 and updated it to become a 99% backward compatible change.
The only change in behavior from previous version is not sending "true" as json body, which was incorrect anyway.
I believe we could even release this as a minor version update.
It depends if we consider it a breaking change or a bugfix that only affects a case of invalid JSON.
Thoughts?