Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/observation #78

Merged
merged 126 commits into from
May 9, 2024
Merged

Feature/observation #78

merged 126 commits into from
May 9, 2024

Conversation

ogis-yamanaka
Copy link
Contributor

OpenTelemetry対応

SaitoMunenori
SaitoMunenori requested changes May 9, 2024
View reviewed changes
Copy link
Contributor

@SaitoMunenori SaitoMunenori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本日の打合せで後で検討すると言っていたかもしれませんが。以下は後日整理が必要かもしれません。

  • 直書きが問題になりそうな箇所（S3のバケット名やリージョンなど）
  • targetRevision がdevelop以外になっている箇所

observation/docs/aws_create.md Outdated Show resolved Hide resolved
observation/docs/aws_delete.md Outdated Show resolved Hide resolved
@ogis-yamanaka
Copy link
Contributor Author

ogis-yamanaka commented May 9, 2024 •
edited
Loading

直書きが問題になりそうな箇所（S3のバケット名やリージョンなど）

こちらは、別途修正いたします。

targetRevision がdevelop以外になっている箇所

最近更新していなくて自信ないですが、確かマージ時に自動的にdevelopに更新したと思います。（GitHubActionsで）

@SaitoMunenori
Copy link
Contributor

最近更新していなくて自信ないですが、確かマージ時に自動的にdevelopに更新したと思います。（GitHubActionsで）

完全にわすれてました

@SaitoMunenori SaitoMunenori merged commit 54c931d into develop May 9, 2024
@SaitoMunenori SaitoMunenori deleted the feature/observation branch May 9, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaitoMunenori SaitoMunenori SaitoMunenori approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ogis-yamanaka @SaitoMunenori