Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #34: Improve error message when no committer configuration is available #193

Conversation

ivanramosnet
Copy link
Contributor

Fix issue #34

You need to setup the git committer identity before using the action. The action fail if it does not find that configuration, at least for the commands that generate a commit. For example if you accidentally did not run

git config --global user.email "you@example.com"
or
git config --global user.name "Your Name"

before using the action.

If you use the action before running either of the config steps, you will see a message that looks something like this:

Git dir: "git dir path" has not been initialized

After applying this pull request you will see a message like this:

Git has not been setup:
  Run
  1. Run 'git config --global user.name <your name>
  2. Run 'git config --global user.email <your email>

@josecelano josecelano linked an issue May 10, 2022 that may be closed by this pull request
@josecelano josecelano added the enhancement New feature or request label May 10, 2022
src/errors.ts Show resolved Hide resolved
src/git-repo.ts Show resolved Hide resolved
@josecelano
Copy link
Member

It seems we do not really need it.

@josecelano josecelano closed this May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error message when no committer configuration is available
2 participants