Device Role and Peer Endpoint Role filters for Peering models #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzbroch
changed the title
glennmatthews
approved these changes
Aug 11, 2023
| @@ -224,6 +224,20 @@ class PeeringFilterSet(BaseFilterSet, CreatedUpdatedFilterSet, CustomFieldModelF | |||
| label="Device (name)", | |||
| ) | |||
|
|
|||
| device_role = django_filters.ModelMultipleChoiceFilter( | |||
| field_name="endpoints__routing_instance__device__device_role__name", | |||
There was a problem hiding this comment.
Do we need to add any prefetch_related/select_related on the Peering list view queryset so as to make this nested lookup not prohibitively expensive at scale?
There was a problem hiding this comment.
Do we need to add any
prefetch_related/select_relatedon the Peering list view queryset so as to make this nested lookup not prohibitively expensive at scale?
Yes, this is a good point. I created new issue to revisit peering list view and modify displayed fields! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new filters for
Peeringmodel:Device RolePeer Endpoint RoleThis will match Peerings by any endpoint side.
TODO: