-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/v3.1.1 #344
Merged
Merged
Release/v3.1.1 #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main to Develop post 3.1.0
* Fix Doc links. * Update Poetry lock The pinned version of aiohappyeyeballs was yanked. * Update poetry.lock
* #333 Fix slack-sdk dependency. * Fixed slack-sdk to version ^3.19.0 for `files_upload_v2`.
* Cookie updated by NetworkToCode Cookie Drift Manager Tool Template: ``` { "template": "https://github.com/nautobot/cookiecutter-nautobot-app.git", "dir": "nautobot-app", "ref": "refs/tags/nautobot-app-v2.4.0", "path": null } ``` Cookie: ``` { "remote": "https://github.com/nautobot/nautobot-app-chatops.git", "path": "/tmp/tmp_5814wh_/nautobot-app-chatops", "repository_path": "/tmp/tmp_5814wh_/nautobot-app-chatops", "dir": "", "branch_prefix": "drift-manager", "context": { "codeowner_github_usernames": "@glennmatthews @jvanderaa @smk4664 @whitej6", "full_name": "Network to Code, LLC", "email": "opensource@networktocode.com", "github_org": "nautobot", "app_name": "nautobot_chatops", "verbose_name": "Nautobot ChatOps App", "app_slug": "nautobot-chatops", "project_slug": "nautobot-app-chatops", "repo_url": "https://github.com/nautobot/nautobot-app-chatops", "base_url": "chatops", "min_nautobot_version": "2.0.0", "max_nautobot_version": "2.9999", "camel_name": "NautobotChatOpsApp", "project_short_description": "Nautobot ChatOps App", "model_class_name": "None", "open_source_license": "Apache-2.0", "docs_base_url": "https://docs.nautobot.com", "docs_app_url": "https://docs.nautobot.com/projects/chatops/en/latest", "_template": "https://github.com/nautobot/cookiecutter-nautobot-app.git", "_output_dir": "/tmp/tmp_5814wh_", "_repo_dir": "/github/home/.cookiecutters/cookiecutter-nautobot-app/nautobot-app", "_checkout": "refs/tags/nautobot-app-v2.4.0" }, "base_branch": "develop", "remote_name": "origin", "pull_request_strategy": "PullRequestStrategy.CREATE", "post_actions": [ "PostAction.RUFF", "PostAction.POETRY" ], "baked_commit_ref": "81d2070deb685f72fb02bf7f73be007d37ce3376", "draft": false } ``` CLI Arguments: ``` { "cookie_dir": "", "input": false, "json_filename": "", "output_dir": "", "push": true, "template": "", "template_dir": "", "template_ref": "refs/tags/nautobot-app-v2.4.0", "pull_request": null, "post_action": [ "ruff", "poetry" ], "disable_post_actions": true, "draft": false } ``` * fix lock file * Add back code removed by Drift Manager * Fix RTD badge location * Delete arch_decision.md This file is unused and unreferenced in mkdocs.yml * Remove duplicate run_command from tasks.py --------- Co-authored-by: bakebot <info@networktocode.com> Co-authored-by: Gary Snider <75227981+gsnider2195@users.noreply.github.com> Co-authored-by: Stephen Kiely <stephenkiely87@gmail.com>
* Update .cookiecutter.json Due to the way that Drift Manager uses the .cookiecutter.json file, we need to change the model_class_name to a valid model in BGP models to help us track drift in files that would be removed if the model_class_name=None. * Create 339.housekeeping * Update changes/339.housekeeping
gsnider2195
requested review from
glennmatthews,
smk4664 and
romanukes
as code owners
November 18, 2024 22:13
gsnider2195
force-pushed
the
release/v3.1.1
branch
from
November 18, 2024 22:19
4cdf1e0
to
6a8d442
Compare
smk4664
reviewed
Nov 18, 2024
@@ -25,7 +25,7 @@ | |||
- Copy the displayed url matching the Server you want to add the chatbot to. | |||
- Make sure to include the `http://` or `https://`. | |||
- If shown, make sure to include the port. Ex. `https://example.com:8065` | |||
6. Proceed to the [Install Guide](../install.md#Install-Guide) section. | |||
6. Proceed to the [Install Guide](../install.md#install-guide) section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commenting, just in case this doesn't work, I know where to look.
smk4664
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's ship it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.1.1 (2024-11-18)
Added
Removed
Fixed
Dependencies
files_upload_v2
.Documentation
Housekeeping
nautobot-app-v2.4.0
.