initial pass on refactor

[whitej6]

No description provided.

[jeffkala]

Did some testing tonight:

1. Can't get secret_group (credential) usage to work.

 {'exc_type': 'FieldError', 'exc_module': 'django.core.exceptions', 'exc_message': ["Cannot resolve keyword 'secret_type' into field. Choices are: _custom_field_data, created, description, destination_for_associations, id, last_updated, name, parameters, provider, secrets_group_associations, secrets_groups, source_for_associations, tagged_items, tags"]} 

Would think it needs to be modified to something like

        if credentials:
           try:
               self.username = credentials.get_secret_value(access_type = SecretsGroupAccessTypeChoices.TYPE_GENERIC, secret_type = SecretsGroupSecretTypeChoices.TYPE_USERNAME)
               self.password = credentials.get_secret_value(access_type = SecretsGroupAccessTypeChoices.TYPE_GENERIC, secret_type = SecretsGroupSecretTypeChoices.TYPE_PASSWORD)
               try:
                   secret = credentials.get_secret_value(access_type = SecretsGroupAccessTypeChoices.TYPE_GENERIC, secret_type = SecretsGroupSecretTypeChoices.TYPE_SECRET)
               except SecretsGroupAssociation.DoesNotExist:
                   self.secret = self.password
           except SecretsGroupAssociation.DoesNotExist:
               # should raise error or also fall back to NAPALM creds?

       else:
           self.username = settings.NAPALM_USERNAME
           self.password = settings.NAPALM_PASSWORD
           self.secret = settings.NAPALM_ARGS.get("secret", None)

If this is required we'd probably want to document the 'default" secret group access type to use.

2. I see odd authentication issues with authentication

 {'exc_type': 'OnboardException', 'exc_module': 'nautobot_device_onboarding.exceptions', 'exc_message': ['fail-general - fail-login - ERROR: Authentication to device failed.\n\nCommon causes of this problem are:\n1. Invalid username (redacted) password\n(redacted) Incorrect SSH-key file\n3. Connecting to the wrong device\n\nDevice settings: autodetect 10.1.1.8:22\n\n\nAuthentication failed: transport shut down or saw EOF']} 

Can ssh from the server directly though. Still trying to figure that one out.
Thinking its an issue with using the settings.NAPALM_* which assumes its in the settings, vs using os.getenv('NAPALM_*. Not sure which one is correct but find it as an antipattern compared to other plugins using those env vars.

The job does function properly when using env_vars instead of settings though.

[scetron]

Overall, looks great!