[WIP] Add DNA Center Integration #451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chadell So we don't forget about the comment in the other PR: How would you like to address supporting the Controller model and/or the ExternalIntegration model as one requires 2.1 and the other 2.2? |
jdrew82
force-pushed
the
feat-dnac_integration
branch
2 times, most recently
from
153fbf1 to
6369a04
Compare
jdrew82
added
the
integration: dna center
…w folder structure/file locations.
…g due to getenv usage.
…on_type instead of doing a search.
…, use 443 if neither found.
…that might same name but differing parents.
… fix tests. Also refactored parse_and_sort_locations to always load Global, even if not used.
…st comprehension.
…t object in fixture and fix log assertion.
…ngs and sort lists in assertion.
…hen Global not loaded.
…issing and sort lists.
…ethods. Also add new setting for deleting locations if True.
jdrew82
force-pushed
the
feat-dnac_integration
branch
from
6369a04 to
b25115b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add the relevant parts for a DNA Center integration. Still has some bits added before it's ready for full review.