Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] DNA Center Integration #446

Closed
wants to merge 69 commits into from
Closed

[WIP] DNA Center Integration #446

wants to merge 69 commits into from

Conversation

jdrew82
Copy link
Contributor

@jdrew82 jdrew82 commented May 2, 2024

This PR is to add a SSoT integration for Cisco DNA Center.

jdrew82 added 30 commits April 23, 2024 10:58
…setting primary.

Also removed unassign_primary() as it's no longer needed.
@jdrew82 jdrew82 self-assigned this May 2, 2024
@jdrew82 jdrew82 requested a review from a team as a code owner May 2, 2024 22:07
@jdrew82 jdrew82 marked this pull request as draft May 2, 2024 22:07
@jdrew82 jdrew82 changed the title DNA Center Integration [WIP] DNA Center Integration May 2, 2024
# Import config vars from nautobot_config.py
PLUGIN_CFG = settings.PLUGINS_CONFIG["nautobot_ssot"]

DNAC_PLATFORM_MAPPER = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add to netutils and use that here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I can look into getting this added to netutils. When I made this I didn't think it was something worth putting in netutils but I can see the value if we add it to the network_driver mapping.

"""DNA Center SSoT Data Source."""

dnac = ObjectVar(
model=ExternalIntegration,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!
what about using the Controller model instead? (and accessing its ExternalIntegration)

Copy link
Contributor Author

@jdrew82 jdrew82 May 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had forgotten about this integration supporting the ExternalIntegration class. I haven't had a chance to support Controller yet. The biggest I problem I see is ExternalIntegration requires 2.1 and Controller 2.2. I know we added ExternalIntegration to CVP recently so we should have made 2.1 minimum but looks like we forgot to update that. Do we want to make 2.2 minimum now or wait for the rest of the updates that will require breaking changes, ie DiffSync 2.0 and some of the Infoblox changes coming from @progala?

@jdrew82 jdrew82 changed the base branch from develop to next May 3, 2024 12:17
@jdrew82
Copy link
Contributor Author

jdrew82 commented May 6, 2024

Going to recreate this as it has commits that shouldn't be included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants