-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] DNA Center Integration #446
Conversation
…setting primary. Also removed unassign_primary() as it's no longer needed.
…bel, and changing Interface.
…tobotIPAddress directly.
…dationError when saving updates.
[Infoblox] Replace `requests.request` with `requests.Session` in the Infoblox API client.
Device42 Unit Tests
Release 2.6.1
Sync Main to Develop for 2.6.1
…w folder structure/file locations.
# Import config vars from nautobot_config.py | ||
PLUGIN_CFG = settings.PLUGINS_CONFIG["nautobot_ssot"] | ||
|
||
DNAC_PLATFORM_MAPPER = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add to netutils and use that here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I can look into getting this added to netutils. When I made this I didn't think it was something worth putting in netutils but I can see the value if we add it to the network_driver mapping.
"""DNA Center SSoT Data Source.""" | ||
|
||
dnac = ObjectVar( | ||
model=ExternalIntegration, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
what about using the Controller model instead? (and accessing its ExternalIntegration)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had forgotten about this integration supporting the ExternalIntegration class. I haven't had a chance to support Controller yet. The biggest I problem I see is ExternalIntegration requires 2.1 and Controller 2.2. I know we added ExternalIntegration to CVP recently so we should have made 2.1 minimum but looks like we forgot to update that. Do we want to make 2.2 minimum now or wait for the rest of the updates that will require breaking changes, ie DiffSync 2.0 and some of the Infoblox changes coming from @progala?
Going to recreate this as it has commits that shouldn't be included. |
This PR is to add a SSoT integration for Cisco DNA Center.