Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device42 Unit Tests #436

Merged
merged 50 commits into from
Apr 29, 2024
Merged

Device42 Unit Tests #436

merged 50 commits into from
Apr 29, 2024

Conversation

jdrew82
Copy link
Contributor

@jdrew82 jdrew82 commented Apr 23, 2024

This PR is to add unit tests to the Device42 integration.

@jdrew82 jdrew82 added type: enhancement New feature or request integration: device42 Issues/PRs for Device42 Integration labels Apr 23, 2024
@jdrew82 jdrew82 self-assigned this Apr 23, 2024
@jdrew82 jdrew82 requested a review from a team as a code owner April 23, 2024 15:18
jdrew82 added 26 commits April 23, 2024 10:58
@jdrew82
build: ⬆️ Upgrade project dependencies
3e645a8
@jdrew82
test: ✅ Add initial test for VRFGroup class
70a6515
@jdrew82
test: ✅ Add test validating VRFGroup.update()
4555eb9
@jdrew82
test: ✅ Add test validating delete() function for NautobotVRFGroup wo…
868ec12 
…rks as expected.
@jdrew82
test: ✅ Add test validating NautobotSubnet.create() functionality
e6f5854
@jdrew82
test: ✅ Add test validating NautobotSubnet.update() functionality.
c640391
@jdrew82
test: ✅ Add test validating NautobotSubnet.delete() functionality.
c4df9c8
@jdrew82
fix: 🐛 Correct attribute to be ip_version
ece83b5
@jdrew82
test: ✅ Add test validating NautobotIPAddress.create() with existing …
5dca067 
…Interface.
@jdrew82
refactor: Move ids and attrs to setUp to be shared
356d206
@jdrew82
test: ✅ Add test showing IPAddress handling when missing Prefix.
7dd78a7
@jdrew82
test: 🚨 Ignore pylint warning
15b66ad
@jdrew82
test: ✅ Add test validating NautobotIPAddress.create() with missing I…
dc403b3 
…nterface
@jdrew82
fix: 🐛 Correct IPAddress Status to be Active if available, else Reser…
e06b5fb 
…ved.
@jdrew82
fix: 🐛 Correct IPAddress update() for assigning to new Interface and …
2c5c415 
…setting primary.

Also removed unassign_primary() as it's no longer needed.
@jdrew82
test: ✅ Add tests validating IPAddress.update() for new available, la…
0094f3e 
…bel, and changing Interface.
@jdrew82
fix: 🐛 Correct var used when updating Device for IPAddress to use sel…
59d4aad 
…f.interface.
@jdrew82
style: 🔥 Remove unused import
353ee51
@jdrew82
test: ♻️ Redo IPAddress update tests to be more DRY.
0ef1d55
@jdrew82
test: ✅ Add test validating NautobotIPAddress.update() for new Device.
9610046
@jdrew82
style: 🚚 Rename test name to be clearer about test.
c67f36f
@jdrew82
test: ✅ Add test validating NautobotIPAddress.update() with changing …
d8e11a3 
…Interface.
@jdrew82
test: ✅ Add test validating NautobotIPAddress.update() when setting p…
ed3bcf3 
…rimary.
@jdrew82
test: ✅ Add test validating NautobotIPAddress.update() when changing …
277a21a 
…tags.
@jdrew82
test: ✅ Add a test validating NautobotIPAddress.update() updating Cus…
2fb94c2 
…tomFields.
@jdrew82
test: ♻️ Use mock_addr for create/update calls instead of calling Nau…
a5d550f 
…tobotIPAddress directly.
jdrew82 added 10 commits April 23, 2024 10:58
@jdrew82
fix: 🐛 Update check for building definition to ensure Global is used …
d58ce56 
…if no building defined.
@jdrew82
test: ✅ Add test validating NautobotVLAN.create() functionality with …
c83c0d3 
…defined building.
@jdrew82
test: ✅ Validate NautobotVLAN.update() functionality with updating VL…
652477e 
…AN name.
@jdrew82
test: ✅ Add test validating NautobotVLAN.update() functions updating …
077ed70 
…VLAN description.
@jdrew82
test: ✅ Add test validating NautobotVLAN.update() updates CustomField…
8fbb0cf 
…s on VLAN.
@jdrew82
test: ✅ Add a test validating NautobotVLAN.update() updates VLAN tags.
a3122ac
@jdrew82
test: ♻️ Redo VRF create/update tests to include tags and CustomFields.
41ca2b8
@jdrew82
test: ✅ Add test validating NautobotVRFGroup.update() clears tags in …
2a3f05c 
…update.
@jdrew82
test: ♻️ Update test for NautobotSubnet.create() to include tags and …
cfc0a73 
…CustomFields.
@jdrew82
test: ✅ Add test validating NautobotSubnet.create() functionality wit…
1fe1270 
…h setting container type.
@jdrew82 jdrew82 force-pushed the patch-d42_tests_fixes branch from 93ff985 to 1fe1270 Compare April 23, 2024 15:59
@jdrew82 jdrew82 merged commit 6130be9 into develop Apr 29, 2024
16 checks passed
@jdrew82 jdrew82 deleted the patch-d42_tests_fixes branch April 29, 2024 13:10
@jdrew82 jdrew82 mentioned this pull request Apr 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kircheneer Kircheneer Kircheneer approved these changes

@glennmatthews glennmatthews Awaiting requested review from glennmatthews glennmatthews is a code owner

@qduk qduk Awaiting requested review from qduk qduk is a code owner

@alhogan alhogan Awaiting requested review from alhogan alhogan is a code owner

@chadell chadell Awaiting requested review from chadell chadell is a code owner

Assignees

@jdrew82 jdrew82

Labels
integration: device42 Issues/PRs for Device42 Integration type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdrew82 @glennmatthews @Kircheneer