Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Infoblox import_subnets setting #242

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

jdrew82
Copy link
Contributor

@jdrew82 jdrew82 commented Oct 11, 2023

This PR should fix the bug that was mentioned in #241. It looks like one of the plugin settings keys got missed being updated for the infoblox_ prepend. This corrects it.

@jdrew82 jdrew82 force-pushed the patch-fix_infoblox_subnet_filter branch from d4d7611 to ae11d00 Compare October 13, 2023 16:49
@jdrew82
Copy link
Contributor Author

jdrew82 commented Oct 13, 2023

I've gone ahead and updated this to include the refactor from the old repo. This should allow support for containers to be included in the subnet filter setting.

@jdrew82 jdrew82 added type: bug Issues/PRs addressing a bug. integration: infoblox Issues/PRs for Infoblox integration labels Oct 16, 2023
Co-authored-by: Eric Jackson <eric-jckson@users.noreply.github.com>
Copy link
Contributor

@Kircheneer Kircheneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdrew82 jdrew82 merged commit d427dcd into develop Oct 17, 2023
14 checks passed
@jdrew82 jdrew82 deleted the patch-fix_infoblox_subnet_filter branch October 17, 2023 15:34
@jdrew82 jdrew82 mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration: infoblox Issues/PRs for Infoblox integration type: bug Issues/PRs addressing a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants