-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Infoblox import_subnets setting #242
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jathanism
force-pushed
the
patch-fix_infoblox_subnet_filter
branch
from
October 12, 2023 18:58
5fdf1b5
to
d4d7611
Compare
This is based off code from @Eric.Jckson in nautobot/nautobot-plugin-ssot-infoblox#143.
jdrew82
force-pushed
the
patch-fix_infoblox_subnet_filter
branch
from
October 13, 2023 16:49
d4d7611
to
ae11d00
Compare
I've gone ahead and updated this to include the refactor from the old repo. This should allow support for containers to be included in the subnet filter setting. |
jdrew82
added
type: bug
Issues/PRs addressing a bug.
integration: infoblox
Issues/PRs for Infoblox integration
labels
Oct 16, 2023
Kircheneer
requested changes
Oct 17, 2023
nautobot_ssot/integrations/infoblox/diffsync/adapters/infoblox.py
Outdated
Show resolved
Hide resolved
nautobot_ssot/integrations/infoblox/diffsync/adapters/infoblox.py
Outdated
Show resolved
Hide resolved
nautobot_ssot/integrations/infoblox/diffsync/adapters/infoblox.py
Outdated
Show resolved
Hide resolved
nautobot_ssot/integrations/infoblox/diffsync/adapters/infoblox.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Eric Jackson <eric-jckson@users.noreply.github.com>
Kircheneer
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the bug that was mentioned in #241. It looks like one of the plugin settings keys got missed being updated for the
infoblox_
prepend. This corrects it.