Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPFabric integration settings updates for 2.0 #246

Merged
merged 4 commits into from
Nov 2, 2023
Merged

IPFabric integration settings updates for 2.0 #246

merged 4 commits into from
Nov 2, 2023

Conversation

alhogan
Copy link
Contributor

@alhogan alhogan commented Oct 13, 2023 •
edited
Loading

  • Cleans up references to configuration settings in code
  • Updates configuration settings names to ensure no conflicts and adhere to standards
  • Adds additional documentation around required and optional configuration settings
  • Fixes a few incorrect defaults for safe delete mode statuses

@alhogan alhogan changed the title U/alhogan ipfabric plugin settings 2.0 IPFabric plugin settings updates for 2.0 Oct 13, 2023
@alhogan alhogan changed the title IPFabric plugin settings updates for 2.0 IPFabric integration settings updates for 2.0 Oct 13, 2023
@alhogan alhogan requested a review from pke11y October 13, 2023 22:31
@alhogan alhogan added the integration: ipfabric Issues/PRs for IPFabric integration label Oct 13, 2023
@alhogan alhogan marked this pull request as ready for review October 13, 2023 22:34
@alhogan alhogan requested a review from a team as a code owner October 13, 2023 22:34
@jdrew82
Copy link
Contributor

jdrew82 commented Oct 17, 2023

@alhogan Can you rebase this on develop? The unit test issues you're seeing in CI are fixed now.

@jdrew82 jdrew82 added the type: bug Issues/PRs addressing a bug. label Oct 31, 2023
@Kircheneer Kircheneer mentioned this pull request Nov 1, 2023
Closed
jdrew82
jdrew82 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the rebase is completed.

@jdrew82 jdrew82 linked an issue Nov 1, 2023 that may be closed by this pull request
SSoT NAUTOBOT - IPFABRIC: django.core.exceptions.ValidationError #240
Closed
@alhogan @jdrew82
Improved the way configuration settings are set
894d6b0 
- All config settings are now prefixed "ipfabric_"
- All config settings are loaded in `constants.py` for reference
- Fixed incorrect safe delete mode statuses
@alhogan @jdrew82
Updated IPFabric examples for consistency
3fa71a2
@alhogan @jdrew82
Updated documentation for settings
b0c1d05 
- Added section on required settings
- Added section on optional settings
- Added warnings for updated setting names
@alhogan @jdrew82
Update site reference to location
757f3ea
@jdrew82 jdrew82 force-pushed the u/alhogan-ipfabric-plugin-settings-2.0 branch from fe7ee15 to 757f3ea Compare November 2, 2023 14:02
@jdrew82 jdrew82 merged commit 345d30e into develop Nov 2, 2023
15 checks passed
@jdrew82 jdrew82 deleted the u/alhogan-ipfabric-plugin-settings-2.0 branch November 2, 2023 14:32
@jdrew82 jdrew82 mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdrew82 jdrew82 jdrew82 approved these changes

@pke11y pke11y Awaiting requested review from pke11y

Assignees

@alhogan alhogan

Labels
integration: ipfabric Issues/PRs for IPFabric integration type: bug Issues/PRs addressing a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSoT NAUTOBOT - IPFABRIC: django.core.exceptions.ValidationError
2 participants
@alhogan @jdrew82