Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookie initialy baked by NetworkToCode Cookie Drift Manager Tool #251

Merged
merged 5 commits into from
Oct 24, 2023
Merged

Cookie initialy baked by NetworkToCode Cookie Drift Manager Tool #251

merged 5 commits into from
Oct 24, 2023

Conversation

snaselj
Copy link
Contributor

@snaselj snaselj commented Oct 20, 2023

Template:

{
    "template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
    "dir": "nautobot-app",
    "ref": "develop",
    "path": null
}

Cookie:

{
    "remote": "https://github.com/nautobot/nautobot-plugin-ssot.git",
    "path": "/opt/ntc/drift-manager/outputs/nautobot-plugin-ssot",
    "repository_path": "/opt/ntc/drift-manager/outputs/nautobot-plugin-ssot",
    "dir": "",
    "branch_prefix": "drift-manager",
    "context": {
        "codeowner_github_usernames": "@smith-ntc",
        "full_name": "Network to Code, LLC",
        "email": "opensource@networktocode.com",
        "github_org": "nautobot",
        "plugin_name": "nautobot_ssot",
        "verbose_name": "Single Source of Truth",
        "plugin_slug": "nautobot-ssot",
        "project_slug": "nautobot-plugin-ssot",
        "repo_url": "https://github.com/nautobot/nautobot-plugin-ssot/",
        "base_url": "ssot",
        "min_nautobot_version": "2.0.0",
        "max_nautobot_version": "2.9999",
        "camel_name": "NautobotSSOTPlugin",
        "project_short_description": "Nautobot Single Source of Truth",
        "model_class_name": "None",
        "open_source_license": "Apache-2.0",
        "docs_base_url": "https://docs.nautobot.com",
        "docs_app_url": "https://docs.nautobot.com/projects/ssot/en/latest",
        "_template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
        "_output_dir": "/opt/ntc/drift-manager/outputs",
        "_repo_dir": "/opt/ntc/drift-manager/outputs/.cookiecutters/cookiecutter-nautobot-app/nautobot-app",
        "_checkout": "develop"
    },
    "base_branch": "develop",
    "remote_name": "origin",
    "pull_request_strategy": "PullRequestStrategy.UPDATE_OR_CREATE",
    "post_actions": [
        "PostAction.BLACK"
    ],
    "baked_commit_ref": "",
    "draft": true
}

CLI Arguments:

{
    "cookie_dir": "",
    "input": false,
    "json_filename": "setup-cookie-ssot.json",
    "output_dir": "./outputs",
    "push": true,
    "template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
    "template_dir": "nautobot-app",
    "template_ref": "develop",
    "pull_request": "update-or-create",
    "post_action": [
        "black"
    ],
    "disable_post_actions": false,
    "draft": true
}

bakebot and others added 4 commits October 20, 2023 07:43
Cookie initialy baked by NetworkToCode Cookie Drift Manager Tool
059b911 
Template:

```
{
    "template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
    "dir": "nautobot-app",
    "ref": "develop",
    "path": null
}
```

Cookie:

```
{
    "remote": "https://github.com/nautobot/nautobot-plugin-ssot.git",
    "path": "/opt/ntc/drift-manager/outputs/nautobot-plugin-ssot",
    "repository_path": "/opt/ntc/drift-manager/outputs/nautobot-plugin-ssot",
    "dir": "",
    "branch_prefix": "drift-manager",
    "context": {
        "codeowner_github_usernames": "@smith-ntc",
        "full_name": "Network to Code, LLC",
        "email": "opensource@networktocode.com",
        "github_org": "nautobot",
        "plugin_name": "nautobot_ssot",
        "verbose_name": "Single Source of Truth",
        "plugin_slug": "nautobot-ssot",
        "project_slug": "nautobot-plugin-ssot",
        "repo_url": "https://github.com/nautobot/nautobot-plugin-ssot/",
        "base_url": "ssot",
        "min_nautobot_version": "2.0.0",
        "max_nautobot_version": "2.9999",
        "camel_name": "NautobotSSOTPlugin",
        "project_short_description": "Nautobot Single Source of Truth",
        "model_class_name": "None",
        "open_source_license": "Apache-2.0",
        "docs_base_url": "https://docs.nautobot.com",
        "docs_app_url": "https://docs.nautobot.com/projects/ssot/en/latest",
        "_template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
        "_output_dir": "/opt/ntc/drift-manager/outputs",
        "_repo_dir": "/opt/ntc/drift-manager/outputs/.cookiecutters/cookiecutter-nautobot-app/nautobot-app",
        "_checkout": "develop"
    },
    "base_branch": "develop",
    "remote_name": "origin",
    "pull_request_strategy": "PullRequestStrategy.UPDATE_OR_CREATE",
    "post_actions": [
        "PostAction.BLACK"
    ],
    "baked_commit_ref": "",
    "draft": true
}
```

CLI Arguments:

```
{
    "cookie_dir": "",
    "input": false,
    "json_filename": "setup-cookie-ssot.json",
    "output_dir": "./outputs",
    "push": true,
    "template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
    "template_dir": "nautobot-app",
    "template_ref": "develop",
    "pull_request": "update-or-create",
    "post_action": [
        "black"
    ],
    "disable_post_actions": false,
    "draft": true
}
```
@snaselj
chore: Manual fixes
8ce6d6f
@snaselj
fix: griffe warning
af6e04e
@snaselj
chore: Remove pylint
9bd0d7e
@snaselj snaselj marked this pull request as ready for review October 20, 2023 10:53
@snaselj snaselj requested a review from a team as a code owner October 20, 2023 10:53
@snaselj
Copy link
Contributor Author

snaselj commented Oct 20, 2023

This PR is ready for review.

cc.: @whitej6

Kircheneer
Kircheneer reviewed Oct 23, 2023
View reviewed changes
Copy link
Contributor

@Kircheneer Kircheneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making some notes, there may not necessarily be anything we need to change in this PR.

development/docker-compose.base.yml Show resolved Hide resolved
development/docker-compose.dev.yml Show resolved Hide resolved
development/docker-compose.dev.yml Show resolved Hide resolved
docs/dev/arch_decision.md Outdated
Comment on lines 1 to 7
# Architecture Decision Records

The intention is to document deviations from a standard Model View Controller (MVC) design.

!!! warning "Developer Note - Remove Me!"
Optional page, remove if not applicable.
For examples see [Golden Config](https://github.com/nautobot/nautobot-plugin-golden-config/tree/develop/docs/dev/dev_adr.md) and [nautobot-plugin-reservation](https://github.com/networktocode/nautobot-plugin-reservation/blob/develop/docs/dev/dev_adr.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the documentation where I was possible to to do. If you can replace this warning with some documentation, would be great. Otherwise, we can remove that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have anything here yet. So IMO we are good to delete it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to:
#255

docs/user/app_overview.md Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
whitej6
whitej6 suggested changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@whitej6 whitej6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kircheneer can you address the two documentation comments?

@Kircheneer Kircheneer merged commit db0b376 into develop Oct 24, 2023
12 checks passed
@jdrew82 jdrew82 mentioned this pull request Nov 6, 2023
Merged
@snaselj snaselj mentioned this pull request Jan 10, 2024
Merged
@nautobot-bot nautobot-bot deleted the drift-manager/pr branch January 29, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kircheneer Kircheneer Kircheneer left review comments

@whitej6 whitej6 whitej6 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snaselj @Kircheneer @whitej6