Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Default Settings Exist for CVP Integration And Fix DeviceRole attribute. #287

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

jdrew82
Copy link
Contributor

@jdrew82 jdrew82 commented Nov 28, 2023

This PR addresses the issue mentioned in #266 where the default settings not being defined causes the Job to crash. I've added checks for the essential settings and raise a MissingConfigSetting exception if not found. This should cause the Job to fail also in 2.0.

@jdrew82 jdrew82 added type: bug Issues/PRs addressing a bug. integration: cloudvision Issues/PRs for the Arista CloudVision SSoT integration. labels Nov 28, 2023
@jdrew82 jdrew82 requested review from qduk and a team as code owners November 28, 2023 20:58
@jdrew82 jdrew82 self-assigned this Nov 28, 2023
@jdrew82 jdrew82 changed the title Validate Default Settings Exist for CVP Integration Validate Default Settings Exist for CVP Integration And Fix DeviceRole attribute. Nov 30, 2023
@jdrew82
Copy link
Contributor Author

jdrew82 commented Nov 30, 2023

This should address the bug that was mentioned in #266 for the device_role attribute. I also found a potential bug in Infoblox integration with the CustomField key possibly having a dash instead of underscores so included fix for that.

@jdrew82 jdrew82 added the integration: infoblox Issues/PRs for Infoblox integration label Nov 30, 2023
Copy link
Contributor

@Kircheneer Kircheneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdrew82 jdrew82 merged commit fd724ed into develop Dec 1, 2023
15 checks passed
@jdrew82 jdrew82 deleted the patch-add_settings_check_cvp branch December 1, 2023 13:03
@jdrew82 jdrew82 mentioned this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration: cloudvision Issues/PRs for the Arista CloudVision SSoT integration. integration: infoblox Issues/PRs for Infoblox integration type: bug Issues/PRs addressing a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants