Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implements caching mechanism into the NautobotAdapter #296

Merged
merged 2 commits into from
Feb 14, 2024
Merged

implements caching mechanism into the NautobotAdapter #296

merged 2 commits into from
Feb 14, 2024

Conversation

Kircheneer
Copy link
Contributor

Re-creation of #184

@Kircheneer
Copy link
Contributor Author

Kircheneer commented Dec 7, 2023 •
edited
Loading

Two points from #184:

  • The cache should also allow for filter queries, not just get ones - I plan to address this in a separate issue
  • The cache should allow for keys that aren't the parameters - I plan to not address this in this PR but open a separate issue

@Kircheneer Kircheneer force-pushed the lk-caching branch 3 times, most recently from 0e07ff3 to acd1a98 Compare December 13, 2023 15:00
@Kircheneer Kircheneer force-pushed the lk-caching branch 3 times, most recently from 5cdb7e8 to 2cfb8fd Compare February 13, 2024 08:07
@Kircheneer Kircheneer marked this pull request as ready for review February 13, 2024 08:09
@Kircheneer Kircheneer requested a review from a team as a code owner February 13, 2024 08:09
chadell
chadell approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (just a small suggestion)

@Kircheneer Kircheneer force-pushed the lk-caching branch 3 times, most recently from 270cd31 to ec2c48b Compare February 13, 2024 11:47
@Kircheneer @chadell
Update nautobot_ssot/tests/test_contrib.py
9e92c77 
Co-authored-by: Christian Adell <chadell@gmail.com>
@Kircheneer Kircheneer mentioned this pull request Feb 13, 2024
Merged
@Kircheneer Kircheneer merged commit 488fabd into nautobot:develop Feb 14, 2024
15 checks passed
@jdrew82 jdrew82 mentioned this pull request Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chadell chadell chadell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kircheneer @chadell