Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store sets in diffsync #320

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Store sets in diffsync #320

merged 3 commits into from
Jan 17, 2024

Conversation

snaselj
Copy link
Contributor

@snaselj snaselj commented Jan 10, 2024 •
edited
Loading

Closes: NaN

When using set() values in DiffSyncModel values, SSoT job failed, due to json.dumps() not being able to serialize set() values.

Will be necessary to implement SSoT for NetBox Importer, as it's using sets for content_types fields values:

nautobot/nautobot-app-netbox-importer#114

What's Changed

  • Added ability to store set() values in Sync.diff fields.

@snaselj snaselj marked this pull request as ready for review January 10, 2024 10:55
@snaselj snaselj requested a review from a team as a code owner January 10, 2024 10:55
Kircheneer
Kircheneer approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@Kircheneer Kircheneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdrew82 jdrew82 merged commit 7a486a6 into develop Jan 17, 2024
15 checks passed
@jdrew82 jdrew82 deleted the u/snaselj-store-diff-set branch January 17, 2024 20:09
@jdrew82 jdrew82 mentioned this pull request Jan 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kircheneer Kircheneer Kircheneer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snaselj @Kircheneer @jdrew82