Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: account for VLAN not having VLANGroup #327

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

jmcgill298
Copy link
Contributor

No description provided.

@jmcgill298 jmcgill298 requested review from qduk, jdrew82 and a team as code owners January 18, 2024 03:14
@jdrew82 jdrew82 added type: bug Issues/PRs addressing a bug. integration: infoblox Issues/PRs for Infoblox integration labels Jan 18, 2024
@jdrew82
Copy link
Contributor

jdrew82 commented Jan 18, 2024

Is this for cases where a VLAN is added outside the Infoblox import? If I remember correctly, Infoblox associates all VLANs to a VLANView, which we import as VLANGroups.

@jmcgill298
Copy link
Contributor Author

Is this for cases where a VLAN is added outside the Infoblox import? If I remember correctly, Infoblox associates all VLANs to a VLANView, which we import as VLANGroups.

TBH, I don't remember how I triggered this, but I did at some point hit an AttributeError for trying to access the name attribute when vlan.vlan_group was not a VLANGroup object.

@jdrew82
Copy link
Contributor

jdrew82 commented Jan 18, 2024

Is this for cases where a VLAN is added outside the Infoblox import? If I remember correctly, Infoblox associates all VLANs to a VLANView, which we import as VLANGroups.

TBH, I don't remember how I triggered this, but I did at some point hit an AttributeError for trying to access the name attribute when vlan.vlan_group was not a VLANGroup object.

Interesting. The only way I can see that happening is if the VLAN and VLANGroup didn't get associated for some reason or a VLAN was added manually without associating to a VLANGroup. EIther way it makes sense to account for this edge case.

Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdrew82 jdrew82 merged commit 6e8fe4f into develop Jan 18, 2024
15 checks passed
@jdrew82 jdrew82 deleted the jacobm/infoblox/bugfix-vlan-wrong-attribute-name branch January 18, 2024 17:03
@jdrew82 jdrew82 mentioned this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration: infoblox Issues/PRs for Infoblox integration type: bug Issues/PRs addressing a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants