Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap IPFabric's database calls around try/except #341

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

jmcgill298
Copy link
Contributor

Wrap the majority of database calls around a try/except to prevent job failure from individual object failure, and add logging about failures

@jmcgill298 jmcgill298 requested review from alhogan and a team as code owners January 27, 2024 04:49
Copy link

@alhogan-aa alhogan-aa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution!

Copy link
Contributor

@alhogan alhogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alhogan alhogan merged commit b961f06 into develop Jan 29, 2024
15 checks passed
@alhogan alhogan deleted the jacobm/wrap-sync-with-try-except branch January 29, 2024 21:12
@jdrew82 jdrew82 mentioned this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants