Jacobm/infoblox/bugfix get ipv4address #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have not tested this yet, but I wanted to get this potential fix available for others |
jmcgill298
force-pushed
the
jacobm/infoblox/bugfix-get-ipv4address
branch
from
e9a7c45
to
6effeb5
Compare
Fixes issue where batches of IPv4 addresses only returns the first result, but the API returns 1 result per entry in the batch. Results are now all returned in a flattened list. Fixes issue where last prefix in the list could have more than 1000 hosts, and then the pending batch of networks less than 1000 is not processed. Enhances building API request by using json type instead of data in order to not perform unneccessary serialization.
jmcgill298
force-pushed
the
jacobm/infoblox/bugfix-get-ipv4address
branch
from
6effeb5
to
b142673
Compare
jmcgill298
added
type: bug
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.