Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing erroneous print statement #581

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Removing erroneous print statement #581

merged 2 commits into from
Oct 23, 2024

Conversation

tsm1th
Copy link
Contributor

@tsm1th tsm1th commented Oct 23, 2024

Stumbled upon a print statement that needs to be removed.

@tsm1th tsm1th requested a review from a team as a code owner October 23, 2024 12:09
@tsm1th tsm1th requested review from qduk and removed request for a team October 23, 2024 12:09
@tsm1th tsm1th self-assigned this Oct 23, 2024
@tsm1th tsm1th linked an issue Oct 23, 2024 that may be closed by this pull request
Erroneous print statement found in sync #582
Closed
@Kircheneer
Copy link
Contributor

Thanks for the submission! We're just missing the change log fragment :)

@tsm1th
Copy link
Contributor Author

tsm1th commented Oct 23, 2024

Sorry about that, just added it.

@jdrew82
Copy link
Contributor

jdrew82 commented Oct 23, 2024

@tsm1th thanks for submitting this! I was just talking to @qduk about this the other day.

@qduk
Copy link
Contributor

qduk commented Oct 23, 2024

@jdrew82 I knew I was forgetting about something yesterday! Thanks @tsm1th taking care of my mistake!

@tsm1th
Copy link
Contributor Author

tsm1th commented Oct 23, 2024

@qduk - No problem! I do it all the time :)

jdrew82
jdrew82 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdrew82 jdrew82 merged commit 73c0048 into develop Oct 23, 2024
16 checks passed
@jdrew82 jdrew82 deleted the tsm1th-bugfix-1 branch October 23, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdrew82 jdrew82 jdrew82 approved these changes

@qduk qduk Awaiting requested review from qduk

Assignees

@tsm1th tsm1th

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Erroneous print statement found in sync
4 participants
@tsm1th @Kircheneer @jdrew82 @qduk