This repository has been archived by the owner on Dec 1, 2023. It is now read-only.
IP Fabric v5 updates #113
Merged
IP Fabric v5 updates #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pke11y
commented
Oct 11, 2022
pke11y
commented
- poetry updates for IPF SDK v5
- updates for snapshot handling
- support for IPF client timeout variable
|
@justinjeffery-ipf and Cristian Cordero, can you guys take a look? |
|
i deployed this branch and test locally, everything looks good from my end 👍 |
chadell
suggested changes
Oct 17, 2022
| @@ -44,7 +45,7 @@ myst-parser = "^0.15.2" | |||
| sphinx-autoapi = "^1.8.4" | |||
| sphinx-rtd-theme = "^1.0.0" | |||
| nautobot-chatops = "^1.5.1" | |||
| nautobot-chatops-ipfabric = "^1.1.1" | |||
| nautobot-chatops-ipfabric = "^2.0.0" | |||
There was a problem hiding this comment.
this implicitly drops support for ipfabric <5.x.x. Should we mention it? (matrix)
There was a problem hiding this comment.
Correct, yes same as ChatOps. Version 5.0+. So yes I'll update the matrix. Good shout.
pyproject.toml
Outdated
| @@ -18,18 +18,19 @@ packages = [ | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = ">=3.7.1,<4.0" | |||
| nautobot = "^1.2.0" | |||
| nautobot = "^1.4.0" | |||
There was a problem hiding this comment.
why do we increase this dependency?
There was a problem hiding this comment.
Probably no reason to really, I can remove.
| nautobot-ssot = "^1.0.1" | ||
| netutils = "^1.0.0" | ||
| ipfabric = "^0" | ||
| ipfabric-diagrams = "~5.0.2" | ||
| ipfabric = "~5.0.11" |
There was a problem hiding this comment.
same comment as below, about support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.