This repository has been archived by the owner on Dec 1, 2023. It is now read-only.
Collect new snapshots #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should force Nautobot to pull new snapshots when a user navigates to the `/extras/jobs/plugins-nautobot_ssot_ipfabric-jobs-ipfabricdatasource/run/` page
ghost
requested review from
ghost
changed the title
|
Tested and now anytime someone goes to the page to start a sync it will now collect new snapshots like it should. |
|
Any idea how we can correctly do this so it updates snapshots once instead of twice? Another customer having issues not viewing recent snapshots and only seeing old data. |
…fabric into collect_new_snapshots
They are able to get a list of snapshots but the sync was not working. This should allow the sync to try to init the IPF client again before erroring.
pke11y
approved these changes
Jul 12, 2023
| @@ -219,6 +225,8 @@ def load_target_adapter(self): | |||
|
|
|||
| def sync_data(self): | |||
| """Sync a device data from IP Fabric into Nautobot.""" | |||
| if self.client is None: | |||
| self.client = self._init_ipf_client() | |||
There was a problem hiding this comment.
could perhaps just refresh the client without checking, but no big deal.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nautobot still was not automatically refreshing snapshots. This should fix the issue.