[Demo]: Updated e2e tests with changes from template-infra #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylew1
changed the title
lorenyu
reviewed
Jul 31, 2024
.github/workflows/e2e-tests.yml
Outdated
Comment on lines
18
to
21
| env: | ||
| BASE_URL: ${{ inputs.service_endpoint }} | ||
| APP_NAME: ${{ inputs.app_name }} | ||
|
|
There was a problem hiding this comment.
nit: delete, doesn't look like this is used anywhere. in the "run e2e tests" step, you use inputs.app_name and inputs.service_endpoint, not env.app_name and env.service_endpoint
There was a problem hiding this comment.
Thanks - looks like it still works with the env definitions removed:
Run make e2e-test APP_NAME=app BASE_URL=http://p-86-app-dev-1797299030.us-east-1.elb.amazonaws.com/
make e[2](https://github.com/navapbc/platform-test-nextjs/actions/runs/10222286732/job/28286717255?pr=86#step:5:2)e-test APP_NAME=app BASE_URL=http://p-86-app-dev-17972990[3](https://github.com/navapbc/platform-test-nextjs/actions/runs/10222286732/job/28286717255?pr=86#step:5:3)0.us-east-1.elb.amazonaws.com
shell: /usr/bin/bash -e {0}
Running [6](https://github.com/navapbc/platform-test-nextjs/actions/runs/10222286732/job/28286717255?pr=86#step:5:7) tests using 1 worker
······
6 passed (8.3s)
Co-authored-by: Loren Yu <loren@navapbc.com>
lorenyu
approved these changes
Aug 2, 2024
|
See the final PR on the Closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves #{TICKET NUMBER OR URL}
Changes
template-infrarepo still workContext for reviewers
This PR still appears to work on this repo:
template-infraPR - Add e2e tests template-infra#694Preview environment