MAIL FROM and DMARC DNS updates #168
Conversation
| resource "aws_route53_record" "dmarc" { | ||
| allow_overwrite = true | ||
| ttl = "600" | ||
| type = "TXT" | ||
| zone_id = var.hosted_zone_id | ||
| records = ["10 feedback-smtp.${data.aws_region.current.name}.amazonaws.com"] | ||
| name = aws_sesv2_email_identity_mail_from_attributes.sender_domain.mail_from_domain | ||
| records = ["v=DMARC1; p=none;"] | ||
| } |
There was a problem hiding this comment.
Non-blocking style suggestion. For email I think dns.tf doesn't really say what it's doing, more how it's doing it. What do you think about instead separating into 3 files:
- mail_from.tf
- dkim.tf
- dmarc.tf
mail_from.tf will have the resources:
- local mail_from variable
- aws_sesv2_email_identity_mail_from_attributes.sender_domain
- aws_route53_record.mx_receive
- aws_route53_record.spf_mail_from
dkim.tf would have:
- aws_route53_record.dkim
and dmarc.tf would have:
- aws_route53_record.dmarc
thoughts?
There was a problem hiding this comment.
While that's probably correct from the point of view of the greater organization of the project, I think it's important to keep the UX in mind here. Splitting up the DNS into 3 files will probably confuse people more often than not. Especially if they don't have strong working knowledge of have email verification works (I certainly don't!)
|
@coilysiren for testing go ahead and apply the changes on the dev environment and look in the console to see if the MAIL FROM shows up as "SUCCESS" rather than pending or failed, and upload a screenshot of that to the PR description |
|
@coilysiren oh even better, use the test notifications page and send an email and show that the email was sent from mail.platform-test-dev.navateam.com |
Co-authored-by: Loren Yu <loren@navapbc.com>
## Changes - Fixes the DNS record for the MAIL FROM domain - Adds the DNS record for the DMARC domain ## Context for reviewers Work originates from https://nava.slack.com/archives/C03G1SWD9H7/p1738089826660819 ## Testing See: navapbc/platform-test#168
|
Should we close this |
|
Done => navapbc/template-infra#859 |
Changes
Context for reviewers
Work originates from https://nava.slack.com/archives/C03G1SWD9H7/p1738089826660819
Testing
Preview environment for app
♻️ Environment destroyed ♻️
Preview environment for app-rails
♻️ Environment destroyed ♻️