Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network layer system design ADR #489

Merged
merged 8 commits into from
Dec 18, 2023
Merged

Network layer system design ADR #489

merged 8 commits into from
Dec 18, 2023

Conversation

lorenyu
Copy link
Contributor

@lorenyu lorenyu commented Dec 4, 2023

Ticket

n/a

Changes

see title

Context for reviewers

Tech spec for defining the network layer

Testing

n/a

@lorenyu lorenyu added this to the Network milestone Dec 4, 2023
@lorenyu lorenyu changed the title WIP Virtual networks system design ADR WIP Network layer system design ADR Dec 4, 2023
@lorenyu lorenyu changed the title WIP Network layer system design ADR Network layer system design ADR Dec 12, 2023
@lorenyu
Copy link
Contributor Author

lorenyu commented Dec 12, 2023

@shawnvanderjagt now that we merged the VPC changes, I think it's a good time to clean up this ADR and merge it in too. Just took a pass and can use a review now.

Copy link
Contributor

@shawnvanderjagt shawnvanderjagt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, I am incredibly excited to see this being added to the template.

@lorenyu lorenyu merged commit 98739d8 into main Dec 18, 2023
1 check passed
@lorenyu lorenyu deleted the lorenyu/vpctechspec branch December 18, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants