Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
n/a
Changes
see title
Context
Most projects need a system architecture diagram that they can review with a security team in order to get the authority to deploy their system to production. This change adds a template system architecture diagram in Lucid.
I know that there are some folks who would prefer these diagrams to be built with Mermaid syntax, and I tried giving that option a good faith effort and I think Mermaid is just not that effective of a tool when visual design matters. In particular, when you want to pack a lot of visual information in a small space so that you can reuse the diagram in documents like Confluence, System Security Plan word docs, etc, having full control over the diagram I think is still the best option. You can see the attempt I did with Mermaid here. I got stuck annotating the protocol/ports, there's no way to make the annotation on one side of the line, the text annotation only sits in the middle of the line, so you can't tell if it's the outgoing port or incoming port. Also, the diagram itself isn't very space efficient, and not very pretty.
Testing
n/a