Remove NAT gateway #499
Merged
Remove NAT gateway #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
N/A
Changes
Context
When implementing non-default VPC in #72, we were running into issues where the ECS cluster would timeout when fetching the container image from ECR. Due to time pressure, we added a NAT gateway as a workaround, which bypasses the networking issues.
The issue was that the S3 Gateway VPC endpoint did not have the route table associations it needed in the route tables for the private subnets. This change adds the required route table associations and removes the NAT gateway that was there as a workaround.
Rollout
NOTE: Network layer changes need to be manually applied on platform-test* repos since the network layer isn't automatically deployed as part of CD
Testing
Developed and tested in platform-test on navapbc/platform-test#73