Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude .venv subfolder for lint-markdown.sh #544

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Exclude .venv subfolder for lint-markdown.sh #544

merged 1 commit into from
Jan 19, 2024

Conversation

yoomlam
Copy link
Contributor

@yoomlam yoomlam commented Jan 19, 2024 •
edited
Loading

Ticket

Resolves lint-markdown.sh unnecessarily analyzes md files under .venv/.

Changes

Exclude files under */.venv/ from being analyzed by adding the arguments -not -path "*/.venv/*".

Context for reviewers

Similar to #543

Testing

  • Instantiate the infra and flask templates into a single repo.
  • Set up the flask application so that a .venv subfolder is populated
  • Run bin/lint-markdown.sh and ensure the md files under the .venv subfolder are not analyzed

@yoomlam yoomlam requested a review from sawyerh January 19, 2024 21:41
@yoomlam yoomlam merged commit c803535 into main Jan 19, 2024
9 checks passed
@yoomlam yoomlam deleted the yoomlam/exclude-py-libraries-from-linter branch January 19, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sawyerh sawyerh sawyerh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoomlam @sawyerh