Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app/service root module aws provider version to >=5.35.0 #731

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

rocketnova
Copy link
Contributor

@rocketnova rocketnova commented Aug 14, 2024

Ticket

Resolves #724

Changes

What was added, updated, or removed in this PR.

  • Update app/service root module aws provider version to >= 5.35.0, < 6.0.0

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers.

This PR updates the /infra/app/service root module's aws provider version. It is currently pinned to >=4.56.0, < 5.0.0. This PR brings it to >= 5.35.0, < 6.0.0.

This supports more recent updates that include data and resource endpoints for AWS Pinpoint and AWS SESv2.

Testing

Provide evidence that the code works as expected. Explain what was done for testing and the results of the test plan. Include screenshots, GIF demos, shell commands or output to help show the changes working as expected. ProTip: you can drag and drop or paste images into this textbox.

Tested on navapbc/platform-test#131, where the "Test service" CI job (with idp enabled) passed. Here's a screenshot verifying the aws provider version used in the CI job was v5.62.0.

CleanShot 2024-08-13 at 17 02 34@2x

⚠️ Breaking changes for release notes

There are breaking changes between aws provider 4.x to 5.x. When upgrading to this version of the infrastructure template, projects should review and follow the aws provider update release notes.

@rocketnova rocketnova requested a review from a team August 14, 2024 00:10
@rocketnova rocketnova merged commit 7a9b157 into main Aug 14, 2024
9 checks passed
@rocketnova rocketnova deleted the rocket/app-service-aws-provider-v5.62.0 branch August 14, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update app service root module to terraform aws provider v5.35.0+
2 participants