Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template CD to use Platform CLI #768

Merged
merged 22 commits into from
Oct 24, 2024
Merged

Conversation

lorenyu
Copy link
Contributor

@lorenyu lorenyu commented Oct 24, 2024

Ticket

n/a

Changes

Update template CD to:

  • Keep lorenyu/platform-cli branch up to date with main
  • Install nava-platform CLI
  • Use nava-platform CLI to update platform-test repos

Context for reviewers

As part of migrating to use the Platform CLI we are going to first get the platform-test* repos to start updating using the Platform CLI

Testing

Temporarily pushed to corresponding lorenyu/platform-cli branches on the platform-test repos:

Successful run: https://github.com/navapbc/template-infra/actions/runs/11508261320

Screenshot of the resulting diff in one of the platform-test repos
image

@lorenyu lorenyu enabled auto-merge (squash) October 24, 2024 22:25
@lorenyu lorenyu disabled auto-merge October 24, 2024 22:25
@lorenyu lorenyu enabled auto-merge (squash) October 24, 2024 22:25
uses: actions/checkout@v4
with:
path: template-infra
ref: lorenyu/platform-cli
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional, right? Because the platform CLI PR hasn't been merged into main yet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct

Copy link
Contributor Author

@lorenyu lorenyu Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're gonna let the template changes (the renaming from app --> {{app_name}} for example) be in a branch for a little while first so that the old scripts can continue to work for a little while

Copy link
Contributor

@coilysiren coilysiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@lorenyu lorenyu merged commit 30bf67d into main Oct 24, 2024
7 checks passed
@lorenyu lorenyu deleted the lorenyu/platform-cli-cd branch October 24, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants