fix(all): Fix possible IE9 style value

- Make element's css value to be string - Revert on 5463150#diff-851f1a6e431d0ae7dc68b646d27821a8R90-R93 Ref #1059
naver · Sep 2, 2019 · 950c335 · 950c335
1 parent 046f9db
commit 950c335
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 15 deletions.
diff --git a/src/plugin/stanford/Elements.js b/src/plugin/stanford/Elements.js
@@ -42,14 +42,14 @@ export default class Elements {
 		// exit
 		stanfordLine.exit().transition()
 			.duration(duration)
-			.style("opacity", 0)
+			.style("opacity", "0")
 			.remove();
 
 		// enter
 		const stanfordLineEnter = stanfordLine.enter().append("g");
 
 		stanfordLineEnter.append("line")
-			.style("opacity", 0);
+			.style("opacity", "0");
 
 		stanfordLineEnter
 			.merge(stanfordLine)
@@ -62,7 +62,7 @@ export default class Elements {
 			.attr("y1", d => (isRotated ? xvCustom(d, "x1") : yvCustom(d, "y1")))
 			.attr("y2", d => (isRotated ? xvCustom(d, "x2") : yvCustom(d, "y2")))
 			.transition()
-			.style("opacity", 1);
+			.style("opacity", "1");
 	}
 
 	updateStanfordRegions(duration) {
@@ -82,18 +82,18 @@ export default class Elements {
 		// exit
 		stanfordRegion.exit().transition()
 			.duration(duration)
-			.style("opacity", 0)
+			.style("opacity", "0")
 			.remove();
 
 		// enter
 		const stanfordRegionEnter = stanfordRegion.enter().append("g");
 
 		stanfordRegionEnter.append("polygon")
-			.style("opacity", 0);
+			.style("opacity", "0");
 
 		stanfordRegionEnter.append("text")
 			.attr("transform", isRotated ? "rotate(-90)" : "")
-			.style("opacity", 0);
+			.style("opacity", "0");
 
 		stanfordRegion = stanfordRegionEnter.merge(stanfordRegion);
 
@@ -108,7 +108,7 @@ export default class Elements {
 				isRotated ? xvCustom(value, "x") : yvCustom(value, "y")
 			].join(",")).join(" "))
 			.transition()
-			.style("opacity", d => (d.opacity ? d.opacity : 0.2));
+			.style("opacity", d => String(d.opacity ? d.opacity : 0.2));
 
 		stanfordRegion.select("text")
 			.transition()
@@ -127,7 +127,7 @@ export default class Elements {
 			.attr("text-anchor", "middle")
 			.attr("dominant-baseline", "middle")
 			.transition()
-			.style("opacity", 1);
+			.style("opacity", "1");
 	}
 
 	updateStanfordElements(duration = 0) {

diff --git a/src/shape/arc.js b/src/shape/arc.js
@@ -443,7 +443,7 @@ extend(ChartInternal.prototype, {
 		mainArc = mainArc.enter().append("path")
 			.attr("class", $$.classArc.bind($$))
 			.style("fill", d => $$.color(d.data))
-			.style("cursor", d => hasInteraction && (config.data_selection_isselectable(d) ? "pointer" : null))
+			.style("cursor", d => (hasInteraction && config.data_selection_isselectable(d) ? "pointer" : null))
 			.style("opacity", "0")
 			.each(function(d) {
 				if ($$.isGaugeType(d.data)) {

diff --git a/src/shape/line.js b/src/shape/line.js
@@ -419,7 +419,7 @@ extend(ChartInternal.prototype, {
 			(withTransition ? $$.mainArea.transition(getRandom()) : $$.mainArea)
 				.attr("d", drawArea)
 				.style("fill", $$.updateAreaColor.bind($$))
-				.style("opacity", d => ($$.isAreaRangeType(d) ? $$.orgAreaOpacity / 1.75 : $$.orgAreaOpacity))
+				.style("opacity", d => String($$.isAreaRangeType(d) ? $$.orgAreaOpacity / 1.75 : $$.orgAreaOpacity))
 		];
 	},
 
@@ -539,8 +539,10 @@ extend(ChartInternal.prototype, {
 
 		$$.mainCircle.exit().remove();
 
+		const fn = $$.point("create", this, $$.pointR.bind($$), $$.color);
+
 		$$.mainCircle = $$.mainCircle.enter()
-			.append($$.point("create", this, $$.pointR.bind($$), $$.color))
+			.append(fn)
 			.merge($$.mainCircle)
 			.style("stroke", $$.color)
 			.style("opacity", $$.initialOpacityForCircle.bind($$));

diff --git a/src/shape/point.js b/src/shape/point.js
@@ -100,10 +100,10 @@ extend(ChartInternal.prototype, {
 						$$.insertPointInfoDefs(point, pointId);
 					}
 
-					if (/^(create|update)$/.test(method)) {
-						method === "create" && args.unshift(pointId);
-
-						return $$.custom[method].bind(context)(element, ...args);
+					if (method === "create") {
+						return $$.custom.create.bind(context)(element, pointId, ...args);
+					} else if (method === "update") {
+						return $$.custom.update.bind(context)(element, ...args);
 					}
 				}