-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subchart.show() gives error in ESM environment #2255
Comments
netil
added a commit
to netil/billboard.js
that referenced
this issue
Aug 17, 2021
Move .unbindZoomEvent() from zoom.ts --> interaction.ts Ref naver#2255
Hi @shashi278 thanks for the report. I'll check the issue. |
netil
added a commit
that referenced
this issue
Aug 17, 2021
Move .unbindZoomEvent() from zoom.ts --> interaction.ts Fix #2255
github-actions bot
pushed a commit
that referenced
this issue
Aug 17, 2021
## [3.1.5](3.1.4...3.1.5) (2021-08-17) ### Bug Fixes * **subchart:** fix subchart esm import failure ([9eede10](9eede10)), closes [#2255](#2255) * **tooltip:** fix tooltip.position call context ([37278e2](37278e2)), closes [#2265](#2265) * **zoom:** fix zoom event triggering for drag type ([f2a049e](f2a049e)), closes [#2254](#2254)
netil
pushed a commit
that referenced
this issue
Aug 17, 2021
## [3.1.5](3.1.4...3.1.5) (2021-08-17) ### Bug Fixes * **subchart:** fix subchart esm import failure ([9eede10](9eede10)), closes [#2255](#2255) * **tooltip:** fix tooltip.position call context ([37278e2](37278e2)), closes [#2265](#2265) * **zoom:** fix zoom event triggering for drag type ([f2a049e](f2a049e)), closes [#2254](#2254)
github-actions bot
pushed a commit
that referenced
this issue
Aug 18, 2021
# [3.2.0-next.3](3.2.0-next.2...3.2.0-next.3) (2021-08-18) ### Bug Fixes * **subchart:** fix subchart esm import failure ([ba6c2b5](ba6c2b5)), closes [#2255](#2255) * **tooltip:** fix tooltip.position call context ([b78a48d](b78a48d)), closes [#2265](#2265) * **zoom:** fix zoom event triggering for drag type ([0a0f039](0a0f039)), closes [#2254](#2254) ### Features * **tooltip:** Enhance tooltip.position passing curr pos ([ec783e9](ec783e9)), closes [#2267](#2267)
github-actions bot
pushed a commit
that referenced
this issue
Oct 7, 2021
# [3.2.0](3.1.5...3.2.0) (2021-10-07) ### Bug Fixes * **axis:** fix y axis stepSize value ([18f6f27](18f6f27)), closes [#2294](#2294) * **bar:** fix data label to be shown for 0 values ([f3634ee](f3634ee)), closes [#2251](#2251) * **event:** make consistent tooltip position on step-after ([5d3a5ed](5d3a5ed)), closes [#2287](#2287) * **gauge:** fix error when interaction=false ([cc4a5e7](cc4a5e7)), closes [#2351](#2351) * **grid:** Make grid elements pass through pointer events ([4db1bcd](4db1bcd)), closes [#2355](#2355) * **grid:** pPrevent error throw ([8fcf61c](8fcf61c)), closes [#2310](#2310) * **plugin:** fix textoverlap plugin ([5e486b5](5e486b5)), closes [#1144](#1144) * **subchart:** fix subchart esm import failure ([ba6c2b5](ba6c2b5)), closes [#2255](#2255) * **tooltip:** fix tooltip.position call context ([b78a48d](b78a48d)), closes [#2265](#2265) * **types:** Allow string dates for zoom() domain ([9cae479](9cae479)), closes [#2316](#2316) [#2333](#2333) * **types:** fix data.onshown/hidden types ([3721c4c](3721c4c)), closes [#2270](#2270) [#2275](#2275) * **types:** Fix type definition for load().json ([25ebb78](25ebb78)), closes [#2334](#2334) * **types:** Fix wrong type definition ([5f7779b](5f7779b)), closes [#2316](#2316) * **zoom:** Fix error throw on drag zoom interaction ([f1dcb27](f1dcb27)), closes [#2343](#2343) * **zoom:** fix zoom event triggering for drag type ([0a0f039](0a0f039)), closes [#2254](#2254) * **zoom:** Fix zoomend call on .zoom() ([9515565](9515565)), closes [#2217](#2217) [#2254](#2254) ### Features * **axis:** Enhance padding to accept px value ([769ec8f](769ec8f)), closes [#2246](#2246) * **error:** Enhance error logging for ESM import ([4b5119c](4b5119c)), closes [#2311](#2311) * **event:** add option for step-before/step-after charts for tooltip to match step behavior ([5f664ba](5f664ba)), closes [#2332](#2332) * **module:** Support dual CJS/ESM package ([ddd8977](ddd8977)), closes [#2202](#2202) * **plugin:** Intent to ship sparkline ([091284e](091284e)), closes [#2285](#2285) * **plugin:** Intent to ship TableView plugin ([6f07e94](6f07e94)), closes [#1873](#1873) * **Subchart:** add subchart x axis tick format option ([da2f3ff](da2f3ff)), closes [#2314](#2314) * **tooltip:** Enhance tooltip.position passing curr pos ([ec783e9](ec783e9)), closes [#2267](#2267)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
I'm trying to use billboard.js in my Vue app but this subchart is not working properly.
I'm getting
$$.unbindZoomEvent is not a function
error when trying to show the subchart usingsubchart.show()
. The same is coming up when usingsubchart.toggle()
for showing the subchart, no problem when hiding.Although I've gone through the docs, I'm not sure if I'm missing something or it's an actual bug. I'd be grateful if someone could have a look at it. Thanks!
billboard.js version: 3.1.4
Steps to check or reproduce
Here's a minimal reproducible example:
App.vue
main.js
And here's the same on codesandbox: https://codesandbox.io/s/billboardjs-subchart-n6rno?fontsize=14&theme=dark&file=/src/main.js:0-358
Update:
The error seems to be coming from 3.1.4 . Switiching back to 3.1.3 resolves my problem.
The text was updated successfully, but these errors were encountered: