Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip in browser does not work anymore? #2550

Closed
mxxrten opened this issue Feb 14, 2022 · 6 comments
Closed

Tooltip in browser does not work anymore? #2550

mxxrten opened this issue Feb 14, 2022 · 6 comments
Labels
bug need-investigate

Comments

@mxxrten
Copy link

mxxrten commented Feb 14, 2022

Description

The tooltip when hovering in the chart does not show anymore in the examples page. It was working last friday. Maybe because of the new 3.3.2 release 9 hours ago?

Steps to check or reproduce

Hovering mouse in chart does not show tooltip. For example on this page:
https://naver.github.io/billboard.js/demo/#Chart.LineChart

When in Chrome pressing F12 and enable mobile preview then it does work again:
image

Tested with up to date Chrome, Edge and Firefox.
@netil
Copy link
Member

netil commented Feb 15, 2022

Hi @mxxrten, tested on chrome(mac & windows), edge, safari and couldn't reproduce the issue.
Try with cleaning up local caches and if not working, provide exact environment info you're using.

Kapture 2022-02-15 at 10 28 33

@netil netil added the question label Feb 15, 2022
@mxxrten
Copy link
Author

mxxrten commented Feb 15, 2022

Thank you for the reply. I tried incognito in Chrome on Windows and clear the cache.
bb.version is 3.3.2.
I see that billboard.js and billboard.css get a 404
image

billboard js broken2

@netil
Copy link
Member

netil commented Feb 21, 2022

I see that billboard.js and billboard.css get a 404

Fallbacks are applied on loading assets. Is because the path on dev local environment and the production is different and is nothing about affecting tooltip interaction at all.

I tested on 2 macs(iMac and Macbook pro) and one windows laptop, none of them were reproducible the issue.
If someone else experiencing same issue, please share it by the comments.

@hjalmers
Copy link

hjalmers commented Mar 8, 2022

@netil I can reproduce the issue and it seems to occur on laptops with touch screens so I assume they're treated as mobile devices. I think the issue was introduced with this commit 👉 0ae640a. I could have a go at it and make a pull request if you want @netil?

@mxxrten
Copy link
Author

mxxrten commented Mar 8, 2022

To confirm, I have indeed a Dell laptop with touchscreen.

hjalmers pushed a commit to hjalmers/billboard.js that referenced this issue Mar 8, 2022
fix(util): Check if agent has mouse
0ef7dba 
Touch devices should allow mouse interaction if a mouse is connected to the device.

Fix naver#2550
@hjalmers hjalmers mentioned this issue Mar 8, 2022
Closed
@netil netil closed this as completed in d42adaa Mar 10, 2022
@netil netil added bug and removed question labels Mar 10, 2022
@netil
Copy link
Member

netil commented Mar 10, 2022

it seems to occur on laptops with touch screens

Seems occurring in that case. I don't possess any touch screen laptop for the real test, but according to the PR sent by @hjalmers can handle this properly.

@mxxrten, checkout the nightly build later if the issue has been fixed.

github-actions bot pushed a commit that referenced this issue Mar 16, 2022
@semantic-release-bot
chore(release): 3.4.0-next.1 [skip ci]
1f422d2 
# [3.4.0-next.1](3.3.3...3.4.0-next.1) (2022-03-16)

### Bug Fixes

* **axis:** Fix culling visibility on dynamic loading ([4c79daf](4c79daf)), closes [#2582](#2582)
* **axis:** fix hidden axis rescale on dynamic load ([5418853](5418853)), closes [#2523](#2523) [#2571](#2571)
* **util:** Check if agent has mouse ([d42adaa](d42adaa)), closes [#2550](#2550) [#2585](#2585)

### Features

* **module:** Support dual CJS/ESM package ([437c007](437c007)), closes [#2202](#2202)
* **plugin:** Intent to ship TableView plugin ([215b611](215b611)), closes [#1873](#1873)
* **polar:** Intent to ship polar type ([feca715](feca715)), closes [#2462](#2462)
github-actions bot pushed a commit that referenced this issue Mar 31, 2022
@semantic-release-bot
chore(release): 3.4.0 [skip ci]
0abcb19 
# [3.4.0](3.3.3...3.4.0) (2022-03-31)

### Bug Fixes

* **api:** Fix flow on indexed/category axis type ([4aba436](4aba436)), closes [#2595](#2595)
* **axis:** Fix culling visibility on dynamic loading ([4c79daf](4c79daf)), closes [#2582](#2582)
* **axis:** fix hidden axis rescale on dynamic load ([5418853](5418853)), closes [#2523](#2523) [#2571](#2571)
* **generator:** Prevent possible infinite loop when tab isn't visible ([bafdb17](bafdb17)), closes [#2606](#2606)
* **option:** Fix data.hide not working for bubble/scatter type ([64ae74b](64ae74b)), closes [#2609](#2609)
* **util:** Check if agent has mouse ([d42adaa](d42adaa)), closes [#2550](#2550) [#2585](#2585)
* **util:** Enhance parsing date string ([8d9f422](8d9f422)), closes [#1714](#1714)

### Features

* **api:** Implement axis range reset ([6c9d99e](6c9d99e)), closes [#2398](#2398)
* **option:** Intent to ship onclick ([63c5a53](63c5a53)), closes [#2587](#2587)
* **polar:** Intent to ship polar type ([feca715](feca715)), closes [#2462](#2462)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug need-investigate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(util): Check if agent has mouse hjalmers/billboard.js
3 participants
@hjalmers @netil @mxxrten