Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release worker URL generated #2778

Closed
netil opened this issue Jul 14, 2022 · 0 comments
Closed

Release worker URL generated #2778

netil opened this issue Jul 14, 2022 · 0 comments
Assignees
@netil
Labels
bug enhancement refactoring

Comments

@netil
Copy link
Member

netil commented Jul 14, 2022 •
edited
Loading

Description

The implementation of boost.useWorker is done by generating URL object on the fly, which is used for worker script.
But is should be released from the memory after its usage to avoid possible memory leak.

And make to reuse Blob object for same function execution.
@netil netil self-assigned this Jul 14, 2022
netil added a commit to netil/billboard.js that referenced this issue Jul 14, 2022
@netil
fix(options): Fix possible memory leak for boost.useWorker
60fa14c 
- Release URL object after worker execution is done
- Reuse Blob object for same function

Ref naver#2778
@netil netil mentioned this issue Jul 14, 2022
Merged
@netil netil closed this as completed in 394d1c3 Jul 14, 2022
github-actions bot pushed a commit that referenced this issue Jul 14, 2022
@semantic-release-bot
chore(release): 3.5.1 [skip ci]
b5b82f6 
## [3.5.1](3.5.0...3.5.1) (2022-07-14)

### Bug Fixes

* **options:** Fix possible memory leak for boost.useWorker ([394d1c3](394d1c3)), closes [#2778](#2778)
* **types:** Fix the signature of the tick format callback for timeseries ([fb246bc](fb246bc)), closes [#2769](#2769)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@netil netil

Labels
bug enhancement refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@netil