Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bar radius not rendered correctly on inverted axis #3054

Closed
netil opened this issue Jan 20, 2023 · 0 comments
Closed

bar radius not rendered correctly on inverted axis #3054

netil opened this issue Jan 20, 2023 · 0 comments
Assignees
Labels

Comments

@netil
Copy link
Member

netil commented Jan 20, 2023

Description

radius isn't rendered correctly for each bar shape.

image

Steps to check or reproduce

bb.generate({
  data: {
    columns: [
	["data1", 80, 250, -200, 200, 250, 150],
	["data2", 170, -350, 240, 200, -250, 150],
	["data3", -120, 100, 240, -300, 350, 350],
	["data4", 180, 130, 340, 200, 250, -250]
    ],
    type: "bar"
  },
  axis: {
    rotated: true,
    y: {
      inverted: true
    }
  },
  bar: {
    radius: {
      ratio: 0.5
    }
  }
});
@netil netil added the bug label Jan 20, 2023
@netil netil self-assigned this Jan 20, 2023
netil pushed a commit to netil/billboard.js that referenced this issue Jan 25, 2023
- Fix negative values drawn radius on rotated axis
- Fix path command to draw correctly on inveted axis

Ref naver#3054
@netil netil closed this as completed in 21b7004 Jan 25, 2023
github-actions bot pushed a commit that referenced this issue Jan 26, 2023
## [3.7.3](3.7.2...3.7.3) (2023-01-26)

### Bug Fixes

* **bar:** Fix bar radius on inverted axis ([21b7004](21b7004)), closes [#3054](#3054)
* **data:** Fix ratio calculation ([519cd0d](519cd0d)), closes [#3055](#3055)
* **type:** align grid api with option interface ([b89b74a](b89b74a)), closes [#3037](#3037)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant