Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

point.focus.only not working on sparkline plugin #3171

Closed
netil opened this issue Apr 7, 2023 · 0 comments
Closed

point.focus.only not working on sparkline plugin #3171

netil opened this issue Apr 7, 2023 · 0 comments
Labels
bug

Comments

@netil
Copy link
Member

netil commented Apr 7, 2023

Description

When point.focus.only=true option is used conjunction with sparkline plugin, data points are hidden and it doesn't render when is hovered.

  point: {
      focus: {
         only: true
      }
  },
  plugins: [
    new bb.plugin.sparkline({ 
     selector: ".sparkline"
    }),
  ],
@netil netil added the bug label Apr 7, 2023
netil pushed a commit to netil/billboard.js that referenced this issue Apr 10, 2023
fix(sparkline): Fix to work point.focus.only option
d1a2664 
Handle point.focus.only option

Ref naver#3171
@netil netil mentioned this issue Apr 10, 2023
Merged
@netil netil closed this as completed in 65b3c1c Apr 10, 2023
github-actions bot pushed a commit that referenced this issue Apr 10, 2023
@semantic-release-bot
chore(release): 3.8.0-next.2 [skip ci]
6449bfa 
# [3.8.0-next.2](3.8.0-next.1...3.8.0-next.2) (2023-04-10)

### Bug Fixes

* **grid:** fix redundant <rect> appends ([1039363](1039363)), closes [#3147](#3147)
* **sparkline:** Fix to work point.focus.only option ([65b3c1c](65b3c1c)), closes [#3171](#3171)

### Features

* **package:** extends root div interface for styling ([0a1fe08](0a1fe08)), closes [#3162](#3162) [#3163](#3163)
github-actions bot pushed a commit that referenced this issue Apr 13, 2023
@semantic-release-bot
chore(release): 3.8.0 [skip ci]
d760c08 
# [3.8.0](3.7.5...3.8.0) (2023-04-13)

### Bug Fixes

* **data:** fix break when whole dataseries are null ([#3134](#3134)) ([5d12c45](5d12c45)), closes [#3124](#3124)
* **grid:** fix redundant <rect> appends ([1039363](1039363)), closes [#3147](#3147)
* **options:** Fix handling for falsy data.types ([5eb731a](5eb731a)), closes [#3125](#3125)
* **sparkline:** Fix to work point.focus.only option ([65b3c1c](65b3c1c)), closes [#3171](#3171)

### Features

* **api:** Enhance resizeAfter for .load/unload APIs ([33bbca4](33bbca4)), closes [#3157](#3157)
* **axis:** Intent to ship axis.x.inverted ([e193c0f](e193c0f)), closes [#3137](#3137)
* **package:** extends root div interface for styling ([0a1fe08](0a1fe08)), closes [#3162](#3162) [#3163](#3163)
* **padding:** Intent to ship padding='fit' ([d760a63](d760a63)), closes [#3118](#3118)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@netil