Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$chart.export() quality #815

Closed
darian314 opened this issue Mar 22, 2019 · 1 comment
Closed

$chart.export() quality #815

darian314 opened this issue Mar 22, 2019 · 1 comment
Labels
feature question
Milestone
3.0

Comments

@darian314
Copy link

Description

Can't set image quality for export image. Is there a place to set pixel density?
@netil
Copy link
Member

netil commented Mar 25, 2019

Hi @darian314, the export is done by serializing svg node and then imported on canvas, where final export is done calling .toDataURL().

According the canvas API, there's parameter for image quality, but I don't think is what you need.

So, for now there's no implicit option for quality, but you can handle with the returning dataURL string.

Maybe this can help:

And I think it'll be good idea implement as new feature.

netil added a commit to netil/billboard.js that referenced this issue Mar 18, 2021
@netil
feat(api): Enhance .export() option to specify size
51cd664 
Make to accept option to specify in different size.

Ref naver#815, naver#1969
@netil netil mentioned this issue Mar 18, 2021
Merged
netil added a commit that referenced this issue Mar 19, 2021
@netil
feat(api): Enhance .export() option to specify size
3c2de80 
Make to accept option to specify in different size.

Close #815
Fix #1969
github-actions bot pushed a commit that referenced this issue Mar 19, 2021
@semantic-release-bot
chore(release): 3.0.0-next.3 [skip ci]
242e307 
# [3.0.0-next.3](3.0.0-next.2...3.0.0-next.3) (2021-03-19)

### Bug Fixes

* **axis:** fix axis.x.max error throw ([de06361](de06361)), closes [#1981](#1981)
* **axis:** fix axis.x.tick.tooltip on rotated axis ([eed2f86](eed2f86)), closes [#1990](#1990)
* **axis:** remove x axis transition during resize ([a938681](a938681)), closes [#1949](#1949)
* **tooltip:** fix linked tooltip recursive call ([b6af8ec](b6af8ec)), closes [#1979](#1979)
* **zoom:** fix zoom on latest chrome ([37edc9b](37edc9b)), closes [/github.com/d3/d3-zoom/issues/231#issuecomment-802305692](https://github.com//github.com/d3/d3-zoom/issues/231/issues/issuecomment-802305692) [#1992](#1992)

### Features

* **api:** Enhance .export() option to specify size ([3c2de80](3c2de80)), closes [#815](#815) [#1969](#1969)
@netil netil added this to the 3.0 milestone Mar 25, 2021
@netil netil closed this as completed Mar 25, 2021
github-actions bot pushed a commit that referenced this issue Mar 26, 2021
@semantic-release-bot
chore(release): 3.0.0 [skip ci]
9285212 
# [3.0.0](2.2.6...3.0.0) (2021-03-26)

### Bug Fixes

* **axis:** fix axis.x.max error throw ([de06361](de06361)), closes [#1981](#1981)
* **axis:** fix axis.x.tick.tooltip on rotated axis ([eed2f86](eed2f86)), closes [#1990](#1990)
* **subchart:** fix duplicated node generation on data load ([d9a5d9a](d9a5d9a)), closes [#2003](#2003)
* **zoom:** fix zoom on latest chrome ([37edc9b](37edc9b)), closes [/github.com/d3/d3-zoom/issues/231#issuecomment-802305692](https://github.com//github.com/d3/d3-zoom/issues/231/issues/issuecomment-802305692) [#1992](#1992)

### Features

* **all:** update for d3 v6 ([2752e55](2752e55)), closes [#1641](#1641)
* **api:** Enhance .export() option to specify size ([3c2de80](3c2de80)), closes [#815](#815) [#1969](#1969)
* **api:** Intent to ship subchart APIs ([5572dc9](5572dc9)), closes [#1993](#1993)
* **candlestick:** Intent to ship candlestick ([8d37bd8](8d37bd8)), closes [#76](#76) [#1167](#1167)
* **candlestick:** Intent to ship candlestick type ([42307cb](42307cb))

### BREAKING CHANGES

* **all:** - Update to work on d3 v6
- Added getPoint() to get event's position coordinate

https://github.com/d3/d3/blob/master/CHANGES.md
https://observablehq.com/d/f91cccf0cad5e9cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature question
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
2 participants
@netil @darian314