Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): Fix wrong type definition #2323

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Conversation

netil
Copy link
Member

@netil netil commented Sep 15, 2021

Issue

#2316

Details

Fix wrong type definition for

  • .load(), .zoom() callback option
  • make prserveAspectRatio option from .export() as optional
  • specify Plugin interface context

Fix wrong type definition for
- .load(), .zoom() callback option
- make prserveAspectRatio option from .export() as optional
- specify Plugin interface context

Ref naver#2316
@netil netil added bug type.d Type definition related labels Sep 15, 2021
@netil netil self-assigned this Sep 15, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.767% when pulling 9216d7d on netil:type.d#2316 into 4fce8cb on naver:master.

@netil netil merged commit 5f7779b into naver:master Sep 15, 2021
@netil netil deleted the type.d#2316 branch September 15, 2021 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug type.d Type definition related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants