Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gauge): fix when has no data #3074

Merged
merged 1 commit into from
Feb 1, 2023
Merged

fix(gauge): fix when has no data #3074

merged 1 commit into from
Feb 1, 2023

Conversation

netil
Copy link
Member

@netil netil commented Feb 1, 2023 •
edited
Loading

Issue

#3066

Details

  • Make background arc to not draw when has no data to show
  • Fix not throw error when empty array is given for data value

Feb-01-2023 16-26-45

fix(gauge): fix when has no data
9e5e948 
Make background arc to not draw when has no data to show

Ref naver#3066
@netil netil added the bug label Feb 1, 2023
@netil netil self-assigned this Feb 1, 2023
@coveralls
Copy link

Coverage Status

Coverage: 90.539% (+0.006%) from 90.532% when pulling 9e5e948 on netil:noData#3066 into f5c0084 on naver:master.

@netil netil merged commit efe7435 into naver:master Feb 1, 2023
@netil netil deleted the noData#3066 branch February 1, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@netil netil

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@netil @coveralls