Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils.$ return wrong element in case of multiple jQuery instances on a document. #11

Closed
sculove opened this issue Jun 5, 2017 · 1 comment
Closed

utils.$ return wrong element in case of multiple jQuery instances on a document. #11

sculove opened this issue Jun 5, 2017 · 1 comment
Labels
🐛Bug help wanted

Comments

@sculove
Copy link
Contributor

sculove commented Jun 5, 2017

Description

When multiple jQuery instances on a documnet and input param is jQuery.

utils.$ don't check jQuery instance.

reference https://stackoverflow.com/questions/1853223/check-if-object-is-a-jquery-object/25004941#25004941

we should fix following code.
https://github.com/naver/egjs-movablecoord/blob/master/src/utils.js#L24
@sculove
Copy link
Contributor Author

sculove commented Jun 5, 2017

we should fix egjs components

sculove added a commit to sculove/egjs-infinitegrid that referenced this issue Jun 7, 2017
@sculove
fix(utils): add defence code
64b2e47 
in case of mutiple jQuery instnaces on a document.

ref naver/egjs-axes#11
@sculove sculove mentioned this issue Jun 7, 2017
Merged
@sculove sculove closed this as completed Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛Bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sculove