Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix scroll method to Infinite module #192

Closed
daybrush opened this issue Jun 19, 2018 · 2 comments
Closed

fix scroll method to Infinite module #192

daybrush opened this issue Jun 19, 2018 · 2 comments
Milestone

Comments

@daybrush
Copy link
Member

Description

  • exist
declare class Infinite {
	constructor(items : ItemManager, options?: {
		isEqualSize?: boolean,
		isConstantSize?: boolean,
		append?: (event?: {cache?: object}) => any,
		append?: (event?: {cache?: object, fit: bool}) => any,
		recycle?: (event?: any) => any,
	});
	scroll(scrollPos: number, isAppend: boolean): void;
}
  • new
declare class Infinite {
	constructor(items : ItemManager, options?: {
		isEqualSize?: boolean,
		isConstantSize?: boolean,
		append?: (event?: {cache: object[]}) => any,
		append?: (event?: {cache: object[], fit: bool}) => any,
		recycle?: (event?: any) => any,
	});
	scroll(scrollPos: number): void;
}

Steps to check or reproduce

@daybrush daybrush added this to the 3.4.0 milestone Jun 19, 2018
@jongmoon
Copy link

@Younkue is change the second parameter from being removed scroll? Why it is removed?

@daybrush
Copy link
Member Author

daybrush commented Jun 21, 2018

@jongmoon isAppend is now a useless parameter.

The scroll now checks all directions.

daybrush added a commit that referenced this issue Jul 5, 2018
…#197)

* fix(GridLayout): fix decimal error
* fix(Layouts): remove startIndex and endIndex
* feat(LayoutManager): add LayoutManager module
* fix(Infinite): fix scroll method
* feat(DOMRenderer): add container option and remove isOverflowScroll
* feat(InfiniteGrid): add useFit option and fix moveTo method
* fix(Infinite): fix scroll and cursor
* test(InfiniteGrid): test LayoutManger and Infinite

Close #135 
Close #173 
Close #185 
Close #186 
Close #192
@daybrush daybrush closed this as completed Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants