fix(all): add keywords, reduce size, export modules #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Younkue I am going to check it 1 hours later If you don't mind. (I'm supporting service now .. ) |
|
@Younkue LGTM, I like your changes. |
|
👍 LGTM |
mixed
approved these changes
Apr 13, 2018
src/ItemManager.js
Outdated
| } else { | ||
| return ItemManager.pluck(this._data, property); | ||
| } | ||
| const data = typeof start === "undefined" ? this._data : this._data.slice(start, (typeof end === "undefined" ? start : end) + 1); |
There was a problem hiding this comment.
I think that It repeat same code that undefined check if condition.
src/ItemManager.js
Outdated
| return this._data.slice(start, start + 1); | ||
| } | ||
| } else { | ||
| if (typeof start === "undefined") { |
src/ItemManager.js
Outdated
| return this._data.concat(); | ||
| } | ||
| return this._data.slice(start, (typeof end === "undefined" ? start : end) + 1); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
All #130
JustifiedLayout.js #122
package.json #136
index.js, index.umd.js #132
Details