Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(WebGLUtils): ignore webgl exception. #199

Merged
merged 3 commits into from
Apr 16, 2018
Merged

refactor(WebGLUtils): ignore webgl exception. #199

merged 3 commits into from
Apr 16, 2018

Conversation

jongmoon
Copy link

Issue

#197

Details

Although there's webgl exception. it should ignore exception.

@jongmoon jongmoon requested a review from daybrush April 16, 2018 07:51
@coveralls
Copy link

coveralls commented Apr 16, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 92.125% when pulling e9c4d72 on jongmoon:PanoViewer#197 into e6f329e on naver:master.

daybrush
daybrush reviewed Apr 16, 2018
View reviewed changes
package.json Outdated
"device-orientation",
"touch",
"VR"
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do you keywords 3d, canvas, 360?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Younkue OK, Thank you!

@daybrush
Copy link
Member

LGTM!

@jongmoon jongmoon merged commit 46fe917 into naver:master Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daybrush daybrush daybrush left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jongmoon @coveralls @daybrush