Add KotlinAndJavaCompositeArbitraryIntrospector for supporting instantiating kotlin class with java reference Type #948

jinia91 · 2024-03-14T02:38:03Z

This is a pr regarding the issue at
#946

I have implemented the KotlinAndJavaCompositeArbitraryIntrospector to facilitate the smooth creation of objects for Kotlin classes that have Java classes as properties.

~~The default Kotlin plugin uses this ArbitraryIntrospector but has been modified to accept other Introspector as a plugin argument.~~

additionaly added a corresponding test case.

~~I personally feel that modifying the behavior of the default kotlin plugin is a bit excessive, so I hope the maintainer will make an appropriate judgment and edit.🙏~~
=> only imple KotlinAndJavaCompositeArbitraryIntrospector

add KotlinAndJavaCompositeArbitraryIntrospector benchmark

How Has This Been Tested?

check through test case

Is the Document updated?

add KotlinAndJavaCompositeArbitraryIntrospector in introspectors-for-kotlin

…a reference type both

…gin api, default introspector

seongahjo · 2024-03-15T15:51:42Z

...m/navercorp/fixturemonkey/kotlin/introspector/KotlinAndJavaCompositeArbitraryIntrospector.kt

+    private val javaIntrospector: ArbitraryIntrospector,
+) : ArbitraryIntrospector {
+    override fun introspect(context: ArbitraryGeneratorContext): ArbitraryIntrospectorResult {
+        val type = Types.getActualType(context.resolvedType)


Perhaps the extension method .actualType() would be better.

seongahjo · 2024-03-15T16:03:44Z

@jinia91
Hello, thank you for your contributing.
It is a known issue so PrimaryConstructorArbitraryIntrospector would implements Matcher in 1.1.x so that it generates only a Kotlin type instance.

Your approach seems to be a good intermediate step in 1.0.x, but I am worried about whether it would cause any performance problems.

Can you add a new benchmark for KotlinAndJavaCompositeArbitraryIntrospector using jmh?

seongahjo · 2024-03-15T16:09:18Z

fixture-monkey-kotlin/src/main/kotlin/com/navercorp/fixturemonkey/kotlin/KotlinPlugin.kt

+class KotlinPlugin(
+    private val kotlinIntrospector: ArbitraryIntrospector = PrimaryConstructorArbitraryIntrospector.INSTANCE,
+    private val javaIntrospector: ArbitraryIntrospector = BeanArbitraryIntrospector.INSTANCE,
+) : Plugin {
    override fun accept(optionsBuilder: FixtureMonkeyOptionsBuilder) {
-        optionsBuilder.objectIntrospector { PrimaryConstructorArbitraryIntrospector.INSTANCE }
+        optionsBuilder.objectIntrospector {
+            KotlinAndJavaCompositeArbitraryIntrospector(
+                kotlinIntrospector = kotlinIntrospector,
+                javaIntrospector = javaIntrospector
+            )
+        }


I think that javaIntrospector is not concern of KotlinPlugin.
It may cause a breaking change in the near future.

It is better to use objectInrospector option to apply new KotlinAndJavaCompositeArbitraryIntrospector with desired javaIntrospector

I also feel that it's excessive for the KotlinPlugin to be setting up the JavaIntrospector. However, it seems good for objects to be smoothly created with the KotlinPlugin alone(dont use other api), regardless of whether Java reference types are used internally.

If a design is planned for a future version (1.1.x) that allows for such behavior,

then in the current PR, I plan to exclude changes to the KotlinPlugin and only keep the implementation of KotlinAndJavaCompositeArbitraryIntrospector.

@jinia91

then in the current PR, I plan to exclude changes to the KotlinPlugin and only keep the implementation of KotlinAndJavaCompositeArbitraryIntrospector.

👍 It is good idea.

seongahjo · 2024-03-15T16:10:39Z

...m/navercorp/fixturemonkey/kotlin/introspector/KotlinAndJavaCompositeArbitraryIntrospector.kt

+    private val kotlinIntrospector: ArbitraryIntrospector,
+    private val javaIntrospector: ArbitraryIntrospector,


How about kotlinArbitraryIntrospector and javaArbitraryIntrospector?

…tlinPlugin

seongahjo · 2024-03-18T01:53:43Z

fixture-monkey-kotlin/src/main/kotlin/com/navercorp/fixturemonkey/kotlin/KotlinPlugin.kt

+import java.lang.reflect.Modifier
 import org.apiguardian.api.API
 import org.apiguardian.api.API.Status.MAINTAINED
-import java.lang.reflect.Modifier


import ordering is not valid

seongahjo · 2024-03-18T01:54:58Z

docs/content/v1.0.x/docs/plugins/kotlin-plugin/introspectors-for-kotlin.md

+        val sut: FixtureMonkey = FixtureMonkey.builder()
+            .plugin(KotlinPlugin())
+            .objectIntrospector(
+                KotlinAndJavaCompositeArbitraryIntrospector(
+                    kotlinArbitraryIntrospector = PrimaryConstructorArbitraryIntrospector.INSTANCE,
+                    javaArbitraryIntrospector = ConstructorPropertiesArbitraryIntrospector.INSTANCE
+                )
+            )
+            .build()


Indentation is not aligned with given.

jinia91 · 2024-03-18T06:05:37Z

README.md

@@ -180,7 +180,7 @@ fun sampleOrder() {
 * @[sangy515](https://github.com/sangy515)
 * @[yunseok-jeong0](https://github.com/yunseok-jeong0)
 * @[wicksome](https://github.com/wicksome)
-* @[Wonjin Choi](https://github.com/jinia91)
+* @[jinia91](https://github.com/jinia91)


is it okay to change my nickname? 🥲

jinia91 · 2024-03-18T06:08:41Z

...-kotlin/src/jmh/kotlin/com/navercorp/fixturemonkey/kotlin/KotlinObjectGenerationBenchMark.kt

@@ -48,4 +49,16 @@ open class KotlinObjectGenerationBenchMark {

    private fun generateKotlinOrderSheet(fixtureMonkey: FixtureMonkey): List<KotlinOrderSheet> =
        List(COUNT) { fixtureMonkey.giveMeOne(KotlinOrderSheet::class.java) }
+
+    @Benchmark


add benchmark for KotlinAndJavaCompositeArbitraryIntrospector

jinia91 · 2024-03-18T06:24:46Z

Benchmark	Mode	Threads	Samples	Score	Score Error (99.9%)	Unit
com.navercorp.fixturemonkey.ManipulationBenchmark.fixed	avgt	1	10	586.739041	3.623991	ms/op
com.navercorp.fixturemonkey.ManipulationBenchmark.thenApply	avgt	1	10	1341.850457	8.021999	ms/op
com.navercorp.fixturemonkey.ObjectGenerationBenchmark.beanGenerateOrderSheetWithFixtureMonkey	avgt	1	10	596.574669	6.019172	ms/op
com.navercorp.fixturemonkey.ObjectGenerationBenchmark.builderGenerateOrderSheetWithFixtureMonkey	avgt	1	10	505.341249	4.760138	ms/op
com.navercorp.fixturemonkey.ObjectGenerationBenchmark.fieldReflectionGenerateOrderSheetWithFixtureMonkey	avgt	1	10	594.315525	10.230895	ms/op
com.navercorp.fixturemonkey.ObjectGenerationBenchmark.jacksonGenerateOrderSheetWithFixtureMonkey	avgt	1	10	666.664955	3.442750	ms/op

Benchmark	Mode	Threads	Samples	Score	Score Error (99.9%)	Unit
com.navercorp.fixturemonkey.kotlin.KotlinObjectGenerationBenchMark.beanGenerateJavaOrderSheetWithFixtureMonkey	avgt	1	10	1015.830312	11.054345	ms/op
com.navercorp.fixturemonkey.kotlin.KotlinObjectGenerationBenchMark.beanGenerateKotlinJavaCompositeOrderSheetWithFixtureMonkey	avgt	1	10	1009.098525	12.771965	ms/op
com.navercorp.fixturemonkey.kotlin.KotlinObjectGenerationBenchMark.beanGenerateKotlinOrderSheetWithFixtureMonkey	avgt	1	10	1040.497933	21.421765	ms/op

seongahjo

👍

jinia91 added 4 commits March 14, 2024 11:18

add test code and enhance kotlin plugin for supporting kotlin and jav…

b1a0be5

…a reference type both

klint formatting

2177a84

add file documentation and mv kotlin plugin test specs

6b914d2

formatting and rollback ununecessary refac

2f5f902

jinia91 marked this pull request as ready for review March 14, 2024 03:10

github-actions bot requested review from acktsap, benelog, jwChung, mhyeon-lee, seongahjo and SooKim1110 March 14, 2024 03:10

github-actions bot assigned jinia91 Mar 14, 2024

jinia91 added 7 commits March 14, 2024 12:50

refac dbb assertion

4fe9074

add KotlinAndJavaCompositeArbitraryIntrospector and change kotlin plu…

4ad828e

…gin api, default introspector

formatting

8194dcf

change to jqwik test

52f4a6e

change to jqwik test

c21262d

del unused import

b989348

add file docu for licence

c12168a

seongahjo reviewed Mar 15, 2024

View reviewed changes

jinia91 added 3 commits March 16, 2024 12:42

feedback(seongahjo) : refac property name and use exist method

4433d51

feedback(seongahjo) : del using kjcompositArbitraryIntrospector in ko…

612404a

…tlinPlugin

add kotlinAndJavaCompositeArbitraryIntrospector doc

7d0db75

jinia91 requested a review from seongahjo March 16, 2024 10:12

jinia91 changed the title ~~Enhance Kotlin Plugin for supporting instantiating kotlin class with java reference Type~~ Add KotlinAndJavaCompositeArbitraryIntrospector for supporting instantiating kotlin class with java reference Type Mar 16, 2024

seongahjo reviewed Mar 18, 2024

View reviewed changes

jinia91 added 4 commits March 18, 2024 14:37

Merge branch 'main' into kotlin-java-composition-object-generate

c1bb28f

formating

cba737c

java and kotlin composite class benchmark test

2e3ed9c

change contributor nick name ^

3f718bc

jinia91 commented Mar 18, 2024

View reviewed changes

jinia91 requested a review from seongahjo March 18, 2024 06:25

seongahjo approved these changes Mar 18, 2024

View reviewed changes

seongahjo merged commit 37b1990 into naver:main Mar 18, 2024
8 checks passed

seongahjo added this to the 1.0.15 milestone Mar 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add KotlinAndJavaCompositeArbitraryIntrospector for supporting instantiating kotlin class with java reference Type #948

Add KotlinAndJavaCompositeArbitraryIntrospector for supporting instantiating kotlin class with java reference Type #948

jinia91 commented Mar 14, 2024 •

edited

Loading

seongahjo Mar 15, 2024

seongahjo commented Mar 15, 2024 •

edited

Loading

seongahjo Mar 15, 2024

jinia91 Mar 16, 2024 •

edited

Loading

seongahjo Mar 16, 2024

seongahjo Mar 15, 2024

seongahjo Mar 18, 2024

seongahjo Mar 18, 2024

jinia91 Mar 18, 2024

jinia91 Mar 18, 2024

jinia91 commented Mar 18, 2024

seongahjo left a comment

		private val kotlinIntrospector: ArbitraryIntrospector,
		private val javaIntrospector: ArbitraryIntrospector,

Add KotlinAndJavaCompositeArbitraryIntrospector for supporting instantiating kotlin class with java reference Type #948

Add KotlinAndJavaCompositeArbitraryIntrospector for supporting instantiating kotlin class with java reference Type #948

Conversation

jinia91 commented Mar 14, 2024 • edited Loading

How Has This Been Tested?

Is the Document updated?

Choose a reason for hiding this comment

seongahjo commented Mar 15, 2024 • edited Loading

Choose a reason for hiding this comment

jinia91 Mar 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jinia91 commented Mar 18, 2024

seongahjo left a comment

Choose a reason for hiding this comment

jinia91 commented Mar 14, 2024 •

edited

Loading

seongahjo commented Mar 15, 2024 •

edited

Loading

jinia91 Mar 16, 2024 •

edited

Loading