Translate the python agent README.md into English #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taeyeon-Kim
reviewed
Apr 5, 2023
| @@ -17,6 +17,8 @@ Scavenger provides more sophisticated and clear UI and elaborate the instrumenta | |||
| * Provide APs for exploring invocations. | |||
| * Scavenger Frontend | |||
| * Provides UI. | |||
| * Scavenger Python Agent (BETA) | |||
| * Python agent of Scavenger Agent described above. | |||
There was a problem hiding this comment.
How about adding a link to the guide as well?
taeyeon-Kim
approved these changes
Apr 14, 2023
junoyoon
reviewed
Apr 23, 2023
scavenger-agent-python/README.md
Outdated
| ### 한계 | ||
| * Graceful Shutdown에 대한 구현은 기존 프레임워크와의 충돌 가능성으로 인해 자동으로 지원하지 않습니다. 대신 아래와 같은 `agent.shutdown()` 함수를 지원하므로 직접 등록하여서 사용하여야 합니다. | ||
| ### Limitations | ||
| * The implementation of Graceful Shutdown is not automatically supported due to potential conflicts with existing frameworks. Instead, the `agent.shutdown()` function as shown below is supported, so you must register and use it yourself. |
There was a problem hiding this comment.
Suggested change
| * The implementation of Graceful Shutdown is not automatically supported due to potential conflicts with existing frameworks. Instead, the `agent.shutdown()` function as shown below is supported, so you must register and use it yourself. | |
| * The implementation of Graceful Shutdown is not automatically supported due to potential conflicts with existing frameworks. Instead, the `agent.shutdown()` function as shown below is provided, so you must register it into your framework shutdown routine by yourself. |
scavenger-agent-python/README.md
Outdated
| @@ -96,4 +97,4 @@ app = Flask(__name__) | |||
| def hello_world(): | |||
| return 'Hello World!' | |||
| ``` | |||
| * 코드를 직접 읽어서 메서드를 탐색해야 하므로 pyc 파일은 현재 지원되지 않습니다. | |||
| * Pyc files are currently not supported because Python code must be read by the agent. | |||
There was a problem hiding this comment.
Suggested change
| * Pyc files are currently not supported because Python code must be read by the agent. | |
| * The direct Instrumentation for pyc files are currently not supported because Python code must be read by the scavenger agent. |
There was a problem hiding this comment.
In that case, how about updating Korean too?
junoyoon
force-pushed
the
update-python-agent-readme
branch
from
4dbf58a
to
0299a3d
Compare
|
@dbgsprw please check the review result |
|
@dbgsprw please. comment sth~ |
dbgsprw
force-pushed
the
update-python-agent-readme
branch
from
131284e
to
829f64a
Compare
|
@junoyoon |
dbgsprw
force-pushed
the
update-python-agent-readme
branch
from
6800eb8
to
49aa4fe
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.