-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a feature for exporting method invocation list #61
Conversation
@cheesecat47 Firstly, thank you so much for your interest in scavenger :) |
@taeyeon-Kim I appreciate your feedback! |
@cheesecat47 <!-- main.js -->
import {faFileExport} from "@fortawesome/free-solid-svg-icons";
iconRegister.add(faFileExport);
<!-- SnapshotTable.vue-->
<el-table-column :label="'$t('message.snapshot.export')'" width="80" align="center">
<template #default="scope">
<el-button circle type="primary" @click="refreshSnapshot(scope.row.id)">
<font-awesome-icon icon="fa-solid fa-file-export"/>
</el-button>
</template>
</el-table-column> I would also like to see this feature changed to allow exporting per snapshot instead of for the entire invocation. |
scavenger-api/src/main/kotlin/com/navercorp/scavenger/dto/ExportMethodInvokationDto.kt
Outdated
Show resolved
Hide resolved
scavenger-api/src/main/kotlin/com/navercorp/scavenger/dto/ExportMethodInvokationDto.kt
Outdated
Show resolved
Hide resolved
scavenger-api/src/main/kotlin/com/navercorp/scavenger/dto/ExportMethodInvokationDto.kt
Outdated
Show resolved
Hide resolved
scavenger-api/src/main/kotlin/com/navercorp/scavenger/dto/ExportMethodInvokationDto.kt
Outdated
Show resolved
Hide resolved
Related PR naver#61
Related PR naver#61
Related PR naver#61 Replace the csv library from apache commons-csv to kotlin-csv. References: - <https://kenta-koyama-biz.gitbook.io/kotlin-csv/#csv-write-examples> - <https://codeburst.io/returning-csv-content-from-an-api-in-spring-boot-63ea82bbcf0f>
Related PR naver#61
scavenger-api/src/main/kotlin/com/navercorp/scavenger/controller/ExportController.kt
Outdated
Show resolved
Hide resolved
scavenger-api/src/main/kotlin/com/navercorp/scavenger/dto/ExportSnapshotMethodDto.kt
Outdated
Show resolved
Hide resolved
...ger-api/src/main/kotlin/com/navercorp/scavenger/repository/ExportSnapshotMethodRepository.kt
Outdated
Show resolved
Hide resolved
scavenger-api/src/main/kotlin/com/navercorp/scavenger/service/ExportSnapshotMethodService.kt
Outdated
Show resolved
Hide resolved
...ger-api/src/main/kotlin/com/navercorp/scavenger/repository/ExportSnapshotMethodRepository.kt
Outdated
Show resolved
Hide resolved
scavenger-entity/src/main/kotlin/com/navercorp/scavenger/entity/ExportSnapshotMethodEntity.kt
Outdated
Show resolved
Hide resolved
scavenger-entity/src/main/kotlin/com/navercorp/scavenger/entity/ExportSnapshotMethodEntity.kt
Outdated
Show resolved
Hide resolved
scavenger-entity/src/main/kotlin/com/navercorp/scavenger/entity/ExportSnapshotMethodEntity.kt
Outdated
Show resolved
Hide resolved
scavenger-api/src/main/kotlin/com/navercorp/scavenger/service/ExportSnapshotMethodService.kt
Outdated
Show resolved
Hide resolved
scavenger-api/src/main/kotlin/com/navercorp/scavenger/service/ExportSnapshotMethodService.kt
Outdated
Show resolved
Hide resolved
@taeyeon-Kim First, thank you for your detailed and kind comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cheesecat47
I left last reviews. please check it.
scavenger-api/src/main/kotlin/com/navercorp/scavenger/controller/ExportController.kt
Outdated
Show resolved
Hide resolved
scavenger-entity/src/main/kotlin/com/navercorp/scavenger/entity/ExportSnapshotMethodEntity.kt
Outdated
Show resolved
Hide resolved
Related PR naver#61 Move exportSnapshotMethod function to SnapshotController. And also modified namings from ExportSnapshotSth to SnapshotExportSth to follow the convention.
Related PR naver#61 Fix the name of SnapshotExportEntity to DbRow because there's no SnapshotExport table in DB.
Related PR naver#61 Modify exportSnapshot() api url from .../export/snapshot/id to .../snapshot/id/export, simillar to refreshSnapshot().
Related PR naver#61 Move SnapshotExportDbRow from scavenger-entity to scavenger-api
@@ -105,7 +105,7 @@ class SnapshotController( | |||
) | |||
} | |||
|
|||
@GetMapping("/customers/{customerId}/export/snapshot/{snapshotId}", produces = ["text/csv"]) | |||
@GetMapping("/customers/{customerId}/snapshot/{snapshotId}/export", produces = ["text/csv"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very good
@cheesecat47 good enough.!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx.. Approved.
Merge
Related PR #61 Replace the csv library from apache commons-csv to kotlin-csv. References: - <https://kenta-koyama-biz.gitbook.io/kotlin-csv/#csv-write-examples> - <https://codeburst.io/returning-csv-content-from-an-api-in-spring-boot-63ea82bbcf0f>
Related PR #61 Fix types and nullables according to schema.sql.
Related PR #61 Remove if statement for checking `err.response.status` code. And also remove the `err` variable like `editSnapshot` function of SnapshotForm.vue, because it seems that there is no usage anymore.
Related PR #61 Fix messages of `message.export` to make it consistent.
Related PR #61 Move exportSnapshotMethod function to SnapshotController. And also modified namings from ExportSnapshotSth to SnapshotExportSth to follow the convention.
Related PR #61 Fix the name of SnapshotExportEntity to DbRow because there's no SnapshotExport table in DB.
Related PR #61 Modify exportSnapshot() api url from .../export/snapshot/id to .../snapshot/id/export, simillar to refreshSnapshot().
Hello, I was impressed with the scavenger presentation at Deview 2023. So I forked this repository as I could use it for something I'm working on.
It's been helpful for me to identify all the methods in my Java project in a short time and know if they are executing or not.
However, in the current version, there was no way to export the collected information on a website (although I can query it directly from the DB). I wanted to contribute, so I added that feature.
This is my first time contributing to open source project, so it may need to be improved on many points. Any feedback would be greatly appreciated.
Here's the description of this PR.