Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify snapshot_nodes table's signature type to text #98

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

sohyun-ku
Copy link
Contributor

#95
Change snapshot_nodes table's signature column type to text.
And add test data
image

@sohyun-ku sohyun-ku self-assigned this Sep 22, 2023
@sohyun-ku sohyun-ku requested a review from a team as a code owner September 22, 2023 05:21
@github-actions
Copy link

github-actions bot commented Sep 22, 2023

Scavenger Test Results

158 files  158 suites   1m 32s ⏱️
263 tests 251 ✔️ 12 💤 0
277 runs  265 ✔️ 12 💤 0

Results for commit 51ccd12.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@taeyeon-Kim taeyeon-Kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two ways to consider this
The first is to append the changeset.
The second is to write a new SQL file and add it to the changelog-master.

databaseChangeLog:
- include:
file: db/changelog/schema.sql
- include:
file: db/changelog/test-data-set.sql
context: local

The second way seems easier to manage, what do you think?


--changeset scavenger:4

TRUNCATE TABLE codebase_fingerprints;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add without truncating?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's possible.
Even though it's still like that...
The test code needs more changes than I thought, so I'll roll back and work on a different PR.

@sohyun-ku
Copy link
Contributor Author

@taeyeon-Kim
I think so too, cause we can see changes without having to check the sql file directly.
I'll change it this way :)

@sohyun-ku sohyun-ku force-pushed the feature/modify-snaphost-node-signature-type branch from 39bdaf6 to 2e7808c Compare September 22, 2023 06:46
@@ -1,6 +1,8 @@
databaseChangeLog:
- include:
file: db/changelog/schema.sql
- include:
file: db/changelog/schema-1.1.1.sql
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe... 1.1.2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha..... fixed in 51ccd12

@sohyun-ku sohyun-ku force-pushed the feature/modify-snaphost-node-signature-type branch from 2e7808c to 51ccd12 Compare September 22, 2023 07:49
Copy link
Contributor

@taeyeon-Kim taeyeon-Kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sohyun-ku sohyun-ku merged commit 87b138e into develop Sep 22, 2023
5 checks passed
@sohyun-ku sohyun-ku deleted the feature/modify-snaphost-node-signature-type branch September 22, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants