-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify snapshot_nodes table's signature type to text #98
Modify snapshot_nodes table's signature type to text #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two ways to consider this
The first is to append the changeset.
The second is to write a new SQL file and add it to the changelog-master.
scavenger/scavenger-schema/src/main/resources/db/changelog/db.changelog-master.yaml
Lines 1 to 6 in b3cd7f9
databaseChangeLog: | |
- include: | |
file: db/changelog/schema.sql | |
- include: | |
file: db/changelog/test-data-set.sql | |
context: local |
The second way seems easier to manage, what do you think?
|
||
--changeset scavenger:4 | ||
|
||
TRUNCATE TABLE codebase_fingerprints; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add without truncating?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's possible.
Even though it's still like that...
The test code needs more changes than I thought, so I'll roll back and work on a different PR.
@taeyeon-Kim |
39bdaf6
to
2e7808c
Compare
@@ -1,6 +1,8 @@ | |||
databaseChangeLog: | |||
- include: | |||
file: db/changelog/schema.sql | |||
- include: | |||
file: db/changelog/schema-1.1.1.sql |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe... 1.1.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha..... fixed in 51ccd12
2e7808c
to
51ccd12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
#95
Change
snapshot_nodes
table'ssignature
column type totext
.And add test data