Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hack used to allow clicking of button when menu is open in DropDownMenu component #802

Open
jschanker opened this issue Nov 13, 2022 · 0 comments
Open

Hack used to allow clicking of button when menu is open in DropDownMenu component #802

jschanker opened this issue Nov 13, 2022 · 0 comments
Labels
bug Something isn't working hack Hack used to get something to work (reference in code comment)

Comments

@jschanker
Copy link
Collaborator

jschanker commented Nov 13, 2022 •
edited
Loading

Describe the bug
A hack was used in commit 30d54fb to get around the presentation layer covering the button when the menu is open. We should look for alternatives later. It seems the MUI team is working on a component to partially accomplish what we want, which we may be able to use instead.

See: mui/material-ui#9893, mui/material-ui#32088

Screenshots
image
@jschanker jschanker added bug Something isn't working enhancement New feature or request issue: triage Issues awaiting triage by a NavGurukul team member labels Nov 13, 2022
jschanker added a commit that referenced this issue Nov 14, 2022
@jschanker
Hack 3 to make button for Dropdown clickable when Menu is open
8b4f203 
Part of Hack #802
@jschanker jschanker added hack Hack used to get something to work (reference in code comment) and removed enhancement New feature or request issue: triage Issues awaiting triage by a NavGurukul team member labels Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working hack Hack used to get something to work (reference in code comment)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jschanker